-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: New nft details page #10277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: New nft details page #10277
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
e6c00d7
feat: New nft details page
sahar-fehri 5b57547
fix: fix conflicts
sahar-fehri 5b14624
fix: fix lint
sahar-fehri ce6585a
fix: unit test
sahar-fehri 995e6b9
fix: fix merge conflicts
sahar-fehri 1a2b538
fix: css in progress
sahar-fehri 0eb02a2
fix: code fencing
sahar-fehri 29be0a5
fix: css in progress ..
sahar-fehri 87a3437
fix: css in progress
sahar-fehri 4a0a32b
fix: add e2e test
sahar-fehri 04f37e5
fix: add full image component
sahar-fehri 17b326b
fix: fix locales
sahar-fehri ce8f4b6
fix: fix locales
sahar-fehri de99844
fix: fix
sahar-fehri f289284
fix: fix
sahar-fehri b9b3571
fix: use Icon component instead of deprecated components
sahar-fehri a683a2a
fix: merge conflicts
sahar-fehri bd8eadf
fix: fix value display
sahar-fehri 03bc553
fix: fix date format
sahar-fehri a094e92
fix: fix patch merge conflicts
sahar-fehri e0b96a9
fix: fix date
sahar-fehri d12b26d
Merge branch 'main' into feat/NFT-details-new-design
sahar-fehri 6e55d4b
fix: update patch types and fix image display
sahar-fehri 7f3a037
fix: cleanup types and fix display when there is only contract address
sahar-fehri 650b520
fix: fix snapshot
sahar-fehri 6f5fbbd
fix: fix link
sahar-fehri 5eab44c
fix: fix test
sahar-fehri 727fe6a
fix: fix locales
sahar-fehri 87571e1
fix: merge conflicts
sahar-fehri a452738
fix: lint
sahar-fehri a39a9a1
fix: fix
sahar-fehri 8d8a662
fix: fix
sahar-fehri f4e73f9
fix: fix e2e
sahar-fehri b6f1f1c
fix: fix android test in progress ..
sahar-fehri 425aff2
fix: update icons
sahar-fehri 0bf29a0
update locator strategy to getElementByID to include an index. Also a…
cortisiko 23d9fc6
fix: fix
sahar-fehri e1e5499
Merge branch 'main' into feat/NFT-details-new-design
sahar-fehri 797dc0a
fix: add track events
sahar-fehri 6a03eb4
fix: fix snapshot
sahar-fehri c8d41a7
fix: update e2e
sahar-fehri 2785201
Merge branch 'main' into feat/NFT-details-new-design
sahar-fehri fcbf86d
fix: review feedback to refactor badge wrapper
sahar-fehri 0551750
fix: remove unused style and rename
sahar-fehri a0f6ff5
fix: update snapshot
sahar-fehri 58a7648
fix: fix e2e matcher
sahar-fehri 4a6c25e
fix: update navbar color icons to default
sahar-fehri f5a7a88
fix: fix merge conflicts
sahar-fehri e0633fd
fix: add sheet design for long tokenId
sahar-fehri 2c410cc
fix: fix conflicts
sahar-fehri 75d1b32
fix: debounce navigation to nft details page
sahar-fehri b4beed8
fix: remove comment
sahar-fehri e4115c1
Merge branch 'main' into feat/NFT-details-new-design
sahar-fehri a56d65f
fix: fix import
sahar-fehri 63719f9
Merge branch 'main' into feat/NFT-details-new-design
sahar-fehri 7acd85c
fix: remove utils fcts and cleanup
sahar-fehri 5075db2
Merge branch 'main' into feat/NFT-details-new-design
sahar-fehri 47387d5
Merge branch 'main' into feat/NFT-details-new-design
sahar-fehri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: add e2e test
- Loading branch information
commit 4a0a32b97f89d8751e6a7da6bbaeface62046346
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| 'use strict'; | ||
|
|
||
| import { SmokeAssets } from '../../tags'; | ||
| import TestHelpers from '../../helpers'; | ||
| import { loginToApp } from '../../viewHelper'; | ||
| import FixtureBuilder from '../../fixtures/fixture-builder'; | ||
| import { | ||
| withFixtures, | ||
| defaultGanacheOptions, | ||
| } from '../../fixtures/fixture-helper'; | ||
| import { SMART_CONTRACTS } from '../../../app/util/test/smart-contracts'; | ||
| import WalletView from '../../pages/wallet/WalletView'; | ||
| import AddCustomTokenView from '../../pages/AddCustomTokenView'; | ||
| import Assertions from '../../utils/Assertions'; | ||
| import enContent from '../../../locales/languages/en.json'; | ||
|
|
||
| describe(SmokeAssets('NFT Details page'), () => { | ||
| const NFT_CONTRACT = SMART_CONTRACTS.NFTS; | ||
| beforeAll(async () => { | ||
| jest.setTimeout(170000); | ||
| await TestHelpers.reverseServerPort(); | ||
| }); | ||
|
|
||
| it('show nft details', async () => { | ||
| await withFixtures( | ||
| { | ||
| dapp: true, | ||
| fixture: new FixtureBuilder() | ||
| .withGanacheNetwork() | ||
| .withPermissionControllerConnectedToTestDapp() | ||
| .build(), | ||
| restartDevice: true, | ||
| ganacheOptions: defaultGanacheOptions, | ||
| smartContract: NFT_CONTRACT, | ||
| }, | ||
| async ({ contractRegistry }) => { | ||
| const nftsAddress = await contractRegistry.getContractAddress( | ||
| NFT_CONTRACT, | ||
| ); | ||
|
|
||
| await loginToApp(); | ||
|
|
||
| await WalletView.tapNftTab(); | ||
| await WalletView.scrollDownOnNFTsTab(); | ||
| // Tap on the add collectibles button | ||
| await WalletView.tapImportNFTButton(); | ||
| await AddCustomTokenView.isVisible(); | ||
| await AddCustomTokenView.typeInNFTAddress(nftsAddress); | ||
| await AddCustomTokenView.typeInNFTIdentifier(1); | ||
| // Click on nft | ||
| await AddCustomTokenView.tapCollectible( | ||
| 'collectible-Test Dapp NFTs #1-1', | ||
| ); | ||
|
|
||
| await Assertions.checkIfTextIsDisplayed(enContent.nft_details.token_id); | ||
| await Assertions.checkIfTextIsDisplayed( | ||
| enContent.nft_details.contract_address, | ||
| ); | ||
| await Assertions.checkIfTextIsDisplayed( | ||
| enContent.nft_details.token_standard, | ||
| ); | ||
| }, | ||
| ); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.