fix: ethereumjs-util -> @ethereumjs/util@^8.1.0 #11979

legobeat · 2024-10-23T14:28:12Z

Description

Replaces legacy ethereumjs-util with maintained @ethereumjs/util.

Related issues

Based on

fix(deps): ethereumjs-util@6->^7.1.5 #11932
- fix(deps): unpin [email protected],x [email protected] #11972

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-23T14:28:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-10-23T14:29:29Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/[email protected]	None	`0`	13.9 kB	types
npm/[email protected]	None	`+2`	214 kB	holgerd77

🚮 Removed packages: npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

github-actions · 2024-10-23T14:41:28Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 88144dc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9aee9078-b4fe-4249-ac78-c02e266e4b86

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-10-24T17:36:16Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a6e2bb1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e925c1a0-778f-4171-94ce-b2edbfbd7e81

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-10-28T11:06:11Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 67d4e9f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/93ab4ee7-0028-4635-ac0f-6210d0baef1c

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

- to get correct types - to prepare upgrading to versions which don't provide the re-export - fix: vendor BNToHex and hexToBN in order to use bn.js v4 - fix: explicitly use either bn.js@4 and bn.js@5 - Why mixing v4 and v5 is A Bad Thing: ethereumjs/ethereumjs-util#250

sonarqubecloud · 2024-10-29T20:03:37Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2025-03-03T14:34:31Z

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

NicolasMassart · 2025-03-07T13:22:07Z

must be reworked after both #11932 and #11972 are merged

NicolasMassart · 2025-10-22T16:17:17Z

This PR is obsolete now

github-actions bot added the team-lavamoat label Oct 23, 2024

legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team Run Smoke E2E and removed team-lavamoat labels Oct 23, 2024

legobeat changed the title ~~deps: ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0~~ fix ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 Oct 23, 2024

legobeat changed the title ~~fix ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0~~ fix: ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 Oct 23, 2024

legobeat mentioned this pull request Oct 23, 2024

fix(deps): ethereumjs-util@6->^7.1.5 #11932

Closed

8 tasks

MetaMask deleted a comment from github-actions bot Oct 23, 2024

legobeat force-pushed the deps-ethereumjs-util-8 branch from 3c97a52 to 88144dc Compare October 23, 2024 14:40

legobeat added Run Smoke E2E and removed Run Smoke E2E labels Oct 23, 2024

legobeat force-pushed the deps-ethereumjs-util-8 branch from 88144dc to a6e2bb1 Compare October 24, 2024 17:33

legobeat added Run Smoke E2E and removed Run Smoke E2E labels Oct 24, 2024

legobeat force-pushed the deps-ethereumjs-util-8 branch from a6e2bb1 to bbedc78 Compare October 25, 2024 01:07

legobeat marked this pull request as ready for review October 25, 2024 01:08

legobeat requested review from a team as code owners October 25, 2024 01:08

legobeat requested a review from a team October 25, 2024 01:08

legobeat requested review from a team as code owners October 25, 2024 01:08

legobeat added the Run Smoke E2E label Oct 28, 2024

legobeat added 10 commits October 29, 2024 19:24

fix(deps): unpin [email protected],x [email protected]

2cee3d6

fix: add package @types/bn.js

1c94317

fix: validateTokenAmount fix

5fc0ac7

lint:fix

da3319c

chore: remove redundant depcheckrc entry

bbcfe81

chore: rename BN to BN4

f9868d0

fix(deps): ethereumjs-util@^6.2.1->^7.1.5

6558a4f

chore: testfix

7e3ed75

deps: ethereumjs-util@^7.1.5->@ethereumjs/util@^8.1.0

bb6feb9

legobeat force-pushed the deps-ethereumjs-util-8 branch from 67d4e9f to bb6feb9 Compare October 29, 2024 19:50

legobeat mentioned this pull request Oct 29, 2024

fix: migrate from deprecated legacy packages #11968

Closed

12 tasks

NicolasMassart self-assigned this Dec 3, 2024

metamaskbot added the external-contributor label Dec 3, 2024

github-actions bot added the stale Issues that have not had activity in the last 90 days label Mar 3, 2025

NicolasMassart added team-mobile-platform Mobile Platform team and removed stale Issues that have not had activity in the last 90 days labels Mar 7, 2025

NicolasMassart marked this pull request as draft March 7, 2025 13:21

NicolasMassart moved this from Needs dev review to Needs more work from the author in PR review queue Mar 7, 2025

NicholasEllul added team-lavamoat and removed team-application-security Application security team labels Sep 25, 2025

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 25, 2025

NicolasMassart closed this Oct 22, 2025

github-actions bot locked and limited conversation to collaborators Oct 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: ethereumjs-util -> @ethereumjs/util@^8.1.0 #11979

fix: ethereumjs-util -> @ethereumjs/util@^8.1.0 #11979

legobeat commented Oct 23, 2024 •

edited by NicolasMassart

Loading

Uh oh!

github-actions bot commented Oct 23, 2024

Uh oh!

socket-security bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 23, 2024 •

edited by metamaskbot

Loading

Uh oh!

github-actions bot commented Oct 24, 2024 •

edited by metamaskbot

Loading

Uh oh!

github-actions bot commented Oct 28, 2024 •

edited by metamaskbot

Loading

Uh oh!

sonarqubecloud bot commented Oct 29, 2024

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

NicolasMassart commented Mar 7, 2025

Uh oh!

NicolasMassart commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

fix: ethereumjs-util -> @ethereumjs/util@^8.1.0 #11979

fix: ethereumjs-util -> @ethereumjs/util@^8.1.0 #11979

Conversation

legobeat commented Oct 23, 2024 • edited by NicolasMassart Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Based on

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 23, 2024

Uh oh!

socket-security bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 23, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Oct 24, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Oct 28, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud bot commented Oct 29, 2024

Quality Gate passed

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

NicolasMassart commented Mar 7, 2025

Uh oh!

NicolasMassart commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

legobeat commented Oct 23, 2024 •

edited by NicolasMassart

Loading

socket-security bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 24, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 28, 2024 •

edited by metamaskbot

Loading