fix: fix duplicated account api calls

[salimtb]

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAssets, SmokeCore, SmokeWalletPlatform, SmokeSwaps, SmokeTrade, SmokeAccounts, SmokeNetworkAbstractions, SmokeMultiChainPermissions, SmokeStake
• Risk Level: high
• AI Confidence: 85%

click to see 🤖 AI reasoning details

These changes are HIGH RISK because they modify critical Engine infrastructure and controller behavior:

1. Engine.ts changes: Reordering controller initialization can affect timing dependencies between controllers. This is in the critical app/core/ path.

2. TokenDetectionController initialization changes: Removing platform: 'mobile' and useAccountsAPI: true parameters changes how tokens are detected, which could affect token appearance in the wallet.

3. Token-balances-controller-messenger changes: Adding many new messenger subscriptions including KeyringController lock/unlock events, TransactionController events, and TokenListController events significantly expands the TokenBalancesController's interaction scope.

4. @metamask-assets-controllers patch: This is a massive patch that:

   • Disables SPOT_PRICES_SUPPORT_INFO for MANY major networks (Ethereum, Polygon, BSC, Arbitrum, Optimism, Base, Linea, Avalanche, etc.) by setting their values to null
   • Adds keyring lock/unlock awareness to TokenBalancesController
   • Changes balance update behavior to check isActive status before updates
   • Adds new methods for token importing and balance filtering

These changes affect:

• Token balance display and updates across all chains
• Token detection and import flows
• Price fetching for tokens (disabled for many networks via null values)
• Lock/unlock wallet interactions with balance updates
• Transaction-triggered balance updates

The changes touch core wallet functionality (token balances, detection), multi-chain behavior (network-specific price support), account management (keyring events), and asset management. Testing should cover assets, wallet core, swaps/trade (which depend on balances), account functionality, network handling, and staking (which shows balances).

View GitHub Actions results