-
Notifications
You must be signed in to change notification settings - Fork 30
adding search bar for project page, and dropdown list on archive page. #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/s-ayush2903/nwoc-website-alpha-version/92m9sy3z0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, revert all the indentation changes and un-necessary whitespace/newline additions in the files. I can see you applied your local indentation on the projects which has resulted in sheer size of the PR, please revert changes like this to speed up the review process because even if we merge this(with un-necessary indentation changes), then other PRs will result in conflicts and then everyone will have to resolve it own their own, which in itself can prove to be a time consuming process
Ok 👌 Will send it you tomorrow 😊 |
@s-ayush2903 @Ankit7Das Please review it !! 🔥 |
@Vishal-raj-1 I can see you've messed up your commit history, I don't want to press this point to clean the history, but you should revert the changes in the file that ain't related to the subject of the issue which this PR targets, like for example, for this PR there should be no changes visible in Also you can maintain clean commit history by keeping your |
let me do one thing, I am closing other two PR and solving three issues in one PR !! |
Description of changes made
@s-ayush2903 @Ankit7Das Please review it before NWOC ends !! |
@s-ayush2903 @Ankit7Das Any update ? Now This PR solve two issues #99 and #91 . For these issues we have to change in I have update PR message and title for the same !! |
@Vishal-raj-1 This isn't how it works, I've told you multiple times that your PR unnecessarily large due formatting changes and I can still see 'em present here, in order to get it merged you'll have to fix this problem |
oh formatting changes. I am doing it right away. |
@s-ayush2903 @Ankit7Das Yep !! It's done now. I have understand my mistake. I have copied archive.html and project.html from master then copy the changes from this PR !! and it's work. Now it is acceptable. |
Good job @Vishal-raj-1! Nice work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Sir !! |
Description of changes made
Submissions guide:
@s-ayush2903 @Ankit7Das Please review it before NWOC ends !!
P.S: I have learn a lot while doing this !! 🔥