-
Notifications
You must be signed in to change notification settings - Fork 30
solve #98 footer is not responsive issue #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/s-ayush2903/nwoc-website-alpha-version/9uo7wiu3u |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the issue this PR targets, we need only the latest commit of this PR as of now, right now you have very old commits from your old branches, you should delete 'em and force push the branch here. Here, you'll need to use reset --hard HEAD
for deleting irrelevant commits in this branch, although this is a very dangerous command, but this'll do the trick needed. Read about it here
No no Sir !! I know this commits message is shown till my branch is not updated with master branch of this repo. doing @s-ayush2903 this is fine now !! check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text now overlaps with the back to top button, this should be fixed
It's done. |
Any Updates @s-ayush2903 ?? |
Ah, it is clean, will merge it now. Was busy in college these days, thanks for pinging 👍 |
No Problem !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue Fix
Fixes #98
Description of changes made
Earlier it was overflowed as mentioned it #98 . for making it responsive what I have done is, I have adding the background color to footer so that it will not overflow now.
Submissions guide:
@s-ayush2903 @Ankit7Das Please look at this PR after merging this #102 one!!