Skip to content

Conversation

Vishal-raj-1
Copy link
Contributor

Issue Fix

Fixes #98

Description of changes made
Earlier it was overflowed as mentioned it #98 . for making it responsive what I have done is, I have adding the background color to footer so that it will not overflow now.

Submissions guide:

  • Have you made corresponding changes to the documentation?
  • Your submission doesn't break any existing feature.
  • Have you lint your code locally prior to submission?

@s-ayush2903 @Ankit7Das Please look at this PR after merging this #102 one!!

@vercel
Copy link

vercel bot commented Jan 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/s-ayush2903/nwoc-website-alpha-version/9uo7wiu3u
✅ Preview: https://nwoc-website-alpha-version-git-fork-vishal-raj-1-footer.s-ayush2903.vercel.app

Copy link
Member

@s-ayush2903 s-ayush2903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the issue this PR targets, we need only the latest commit of this PR as of now, right now you have very old commits from your old branches, you should delete 'em and force push the branch here. Here, you'll need to use reset --hard HEAD for deleting irrelevant commits in this branch, although this is a very dangerous command, but this'll do the trick needed. Read about it here

@Vishal-raj-1
Copy link
Contributor Author

For the issue this PR targets, we need only the latest commit of this PR as of now, right now you have very old commits from your old branches, you should delete 'em and force push the branch here. Here, you'll need to use reset --hard HEAD for deleting irrelevant commits in this branch, although this is a very dangerous command, but this'll do the trick needed. Read about it here

No no Sir !! I know this commits message is shown till my branch is not updated with master branch of this repo. doing git pull upstream master and git push works here.

@s-ayush2903 this is fine now !! check it

Copy link
Member

@s-ayush2903 s-ayush2903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text now overlaps with the back to top button, this should be fixed

@Vishal-raj-1
Copy link
Contributor Author

The text now overlaps with the back to top button, this should be fixed

It's done.

@s-ayush2903 s-ayush2903 requested a review from Ankit7Das January 9, 2021 21:15
@Vishal-raj-1
Copy link
Contributor Author

It's done.

Any Updates @s-ayush2903 ??

@s-ayush2903
Copy link
Member

Ah, it is clean, will merge it now. Was busy in college these days, thanks for pinging 👍

@Vishal-raj-1
Copy link
Contributor Author

Ah, it is clean, will merge it now. Was busy in college these days, thanks for pinging 👍

No Problem !!

Copy link
Member

@s-ayush2903 s-ayush2903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-ayush2903 s-ayush2903 merged commit 744f566 into NJACKWinterOfCode:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

footer is not responsive
2 participants