Repository navigation
Add reference to jev-php in README.md - #1006
f-lombardo wants to merge 2 commits into
Conversation
|
Thank you for this, and for adding laya support to jev-php in the first place. I am going to leave the decision to @NandhaKishorM rather than merge it myself, and I would rather say why than let it sit without an answer. The change is factually correct and on-topic. That paragraph is about Jev wire-protocol compatibility, it already names Two things make it not mine to merge. It is a listing of a project in this project's README, which is a brand and ecosystem decision rather than a technical one, and the project is your own, so it is a self-listing. Neither is a criticism: maintainers add community clients to READMEs all the time, and the precedent in that very sentence suggests this one would be welcome. It is just a call the maintainer should make rather than something I should wave through on a maintenance pass. I have flagged it to him directly, so this is not stalled pending anything from you. If he says yes it is a one-click merge. For what it is worth on the substance: a client that already speaks the Jev protocol needing only its |
|
Not merging this, and I checked the target before deciding rather than going on the name.
That inverts the sentence it would join. The existing entry, This is not a comment on the library, which looks like a decent typed client and which documents the laya path properly, including the Docker quickstart. It is about the one thing this README is relied on for: a reader checking that nothing here sends their states to someone else's service. If you add a laya-first entry point to the library, one where the default is a local |
What
Add reference to jev-php in README.md
Why
Jev-php added support for laya in its last release
Checklist
main