Skip to content

Add reference to jev-php in README.md - #1006

Closed
f-lombardo wants to merge 2 commits into
NandhaKishorM:mainfrom
f-lombardo:main
Closed

f-lombardo wants to merge 2 commits into
NandhaKishorM:mainfrom
f-lombardo:main

Conversation

@f-lombardo

@f-lombardo f-lombardo commented Oct 6, 2026 •

Copy link
Copy Markdown

What

Add reference to jev-php in README.md

Why

Jev-php added support for laya in its last release

Checklist

  • Focused on one change (split unrelated work into another PR)
  • Rebased on the latest main
  • Tests pass locally
  • Docs or examples updated when the public API changed

@NandhaKishorM

Copy link
Copy Markdown
Owner

Thank you for this, and for adding laya support to jev-php in the first place. I am going to leave the decision to @NandhaKishorM rather than merge it myself, and I would rather say why than let it sit without an answer.

The change is factually correct and on-topic. That paragraph is about Jev wire-protocol compatibility, it already names getmissionctrl/hs-jev and marcreichel/laya-php, and a second PHP client that targets laya-serve belongs in the same sentence by the same logic.

Two things make it not mine to merge. It is a listing of a project in this project's README, which is a brand and ecosystem decision rather than a technical one, and the project is your own, so it is a self-listing. Neither is a criticism: maintainers add community clients to READMEs all the time, and the precedent in that very sentence suggests this one would be welcome. It is just a call the maintainer should make rather than something I should wave through on a maintenance pass.

I have flagged it to him directly, so this is not stalled pending anything from you. If he says yes it is a one-click merge.

For what it is worth on the substance: a client that already speaks the Jev protocol needing only its baseUrl repointed is the clearest demonstration of the compatibility claim in that paragraph, so it is useful evidence for the sentence it sits in, not just a link.

@NandhaKishorM

Copy link
Copy Markdown
Owner

Not merging this, and I checked the target before deciding rather than going on the name.

f-lombardo/jev-php is a Jev client whose default endpoint is https://api.typesafe.ai/v1/systemone, a hosted service, with a TypeSafe API key required. Laya support is a second mode where the caller supplies LAYA_URL, shown as the placeholder https://your-laya-endpoint/v1/systemone.

That inverts the sentence it would join. The existing entry, marcreichel/laya-php, is described as a client that "targets laya-serve rather than Jev", and the whole point of that line is that a PHP user who does not want a hosted API has somewhere to go. Adding a client that defaults to a hosted API and needs a vendor key, under the same sentence and the same "rather than Jev" framing, tells a reader the opposite of what is true for it.

This is not a comment on the library, which looks like a decent typed client and which documents the laya path properly, including the Docker quickstart. It is about the one thing this README is relied on for: a reader checking that nothing here sends their states to someone else's service.

If you add a laya-first entry point to the library, one where the default is a local laya-serve and no key is involved, I would list it on that basis and it would read truthfully next to the existing one.

@f-lombardo f-lombardo mentioned this pull request Oct 18, 2026
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants