Skip to content

Add Jev-PHP library - #1280

Closed
f-lombardo wants to merge 1 commit into
NandhaKishorM:mainfrom
f-lombardo:main
Closed

f-lombardo wants to merge 1 commit into
NandhaKishorM:mainfrom
f-lombardo:main

Conversation

@f-lombardo

Copy link
Copy Markdown

What

Add reference to jev-php in README.md.

Why

Jev-php added support for laya besides Jev. (See #1006)

Checklist

  • Focused on one change (split unrelated work into another PR)
  • Rebased on the latest main
  • Tests pass locally
  • Docs or examples updated when the public API changed#

@NandhaKishorM

Copy link
Copy Markdown
Owner

Thank you for taking the point and relabelling it. The new wording is honest in the way the old one was not: naming Jev as the main target is exactly the fact a reader needed, and I would rather have had this version first time.

I am still not merging it, and the reason has moved from accuracy to placement. The sentence it joins exists to tell a PHP user where to go if they do not want a hosted service: it introduces marcreichel/laya-php as a client that targets laya-serve "rather than Jev". Appending a client whose main target is TypeSafe's hosted Jev, with https://api.typesafe.ai/v1/systemone as its default and a vendor key required, puts a pointer to a hosted provider inside the one line of this README that is about avoiding one. That is a standing rule here rather than a judgement about your library, which documents its Laya path properly and has a working Docker quickstart.

The same offer as before stands and is the only thing in the way: a laya-first entry point, where the default is a local laya-serve and no key is involved. Then it is a laya client that also speaks Jev, rather than a Jev client that also speaks laya, and it belongs in that sentence on its own merits.

Two small things if it comes back: the link text reads Jev-PHO rather than jev-php, and "alongside with another PHP client" wants to be "alongside another PHP client".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants