Replace store statics #482
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Using |
Member
Author
|
Of course this breaks the provisioner app which wants a mutable reference to the storage so that it can format the filesystem. Maybe we can just drop that feature. I don’t think we use it during provisioning, and for development devices, we have other means to format the IFS. |
Collaborator
|
I think it should be fine to drop support for it - that's usually anyways only needed during provisioning - for development we have the debugger to do this job |
robin-nitrokey
force-pushed
the
static-mut
branch
from
7a9b52b to
428f262
Compare
The ReformatFilesystem command requires unsafe direct access to the storage used by Trussed. As it is not actually used, this patch removes it from the provisioner app.
This patch moves the statics storing the various storage components into the local resources for the init tasks. This makes them sound and safe to use. Unfortunately, this leads to a significant increase in binary size.
robin-nitrokey
force-pushed
the
static-mut
branch
from
428f262 to
7e3cc3e
Compare
Collaborator
|
No significant changes. Insignifcant changes
|
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the statics storing the various storage components into
the local resources for the init tasks. This makes them sound and safe
to use. Unfortunately, this leads to a significant increase in binary
size.
Based on: