Simplify Store implementation #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
No significant changes. Insignifcant changes
|
robin-nitrokey
force-pushed
the
dyn-fs
branch
2 times, most recently
from
41e638b to
e6f1cfe
Compare
daringer
approved these changes
Mar 3, 2025
This patch updates trussed to use the simplified Store trait.
This temporarily reverts #594 as the current implementation does not work with merge commits.
robin-nitrokey
added a commit
that referenced
this pull request
Mar 4, 2025
The old logic can lead to problems when the job runs for the first time for a commit on main, e. g. after a merge with a merge commit (instead of a fast-forward merge), as the "root" of the branch is equal to the head and there are no cached metrics for the head. This also reverts the temporary change to ignore errors curing comment creation in #600 as the cause should be fixed with this PR.
robin-nitrokey
added a commit
that referenced
this pull request
Mar 4, 2025
The old logic can lead to problems when the job runs for the first time for a commit on main, e. g. after a merge with a merge commit (instead of a fast-forward merge), as the "root" of the branch is equal to the head and there are no cached metrics for the head. This also reverts the temporary change to ignore errors during comment creation in #600 as the cause should be fixed with this PR.
This was referenced Mar 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates trussed to use the simplified Store trait, see:
Depends on: