-
Notifications
You must be signed in to change notification settings - Fork 737
Fix Nuget Solution Package manager UI is slow because restore is run for every project instead of after all projects are updated #3559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erdembayar
merged 84 commits into
dev
from
dev-eryondon-PMUIslowBecauseRestorerunsforEveryProjectInsteadofAllProjectsAreUpdated
Sep 3, 2020
Merged
Changes from all commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
a49aecd
Added relationship table to hold ancesstors and descendents relations…
erdembayar ee3e059
Now 1065 is solved because we pass correct update PackageSpec of chil…
erdembayar 7c5eaf4
Remove RelationshipTree for now.
erdembayar 3e3a9cd
Add unshipped public api.
erdembayar 0b1c6d0
Remove unused item and add initial value to dictionary to prevent fro…
erdembayar 875968b
More streamline package reference type code restore.
erdembayar b78a8c8
Revert "More streamline package reference type code restore."
erdembayar ac8ae7a
Restore NugetBuiltIntegrated restore works only in 1 pass.
erdembayar 8a919a0
Minor refactoring for naming.
erdembayar de82bb9
Explicit clearing of cache.
erdembayar 049388a
Initial refactoring of moving caching of updated PackageSpec near to …
erdembayar 5a7eee8
Made BuiltIntegratedProject project upgrade/downgrade parallel run fo…
erdembayar 7cca356
Fix minor typos.
erdembayar e8ff4fa
Remove unused methods and variables.
erdembayar efa1782
Remove more unused item.
erdembayar f0ce777
Revert "Remove more unused item."
erdembayar cc68cd6
Patching in memory works.
erdembayar d070102
Cleanup
erdembayar 41d2762
Minor text change
erdembayar db54f02
More code cleanup.
erdembayar abe53cb
Rename PreviewBuildIntegratedProjectActionsParallelAsync method to Pr…
erdembayar 9d46759
Add unit tests for covering PreviewBuildIntegratedProjectsActionsAsyn…
erdembayar c0cb7f5
Add more unit tests for BuildIntegratedTests
erdembayar 1f8ad2f
Address Andy's code review comment.
erdembayar 8e5b0dd
Add unit test for DependencyGraphSpec>>WithReplacedPackageSpecs new m…
erdembayar 790fdac
Get Andy's advise for reduce runtime time complexity.
erdembayar 2aafd95
Change package versions because it's failing on .NetCore unit tests.
erdembayar 1a67342
Check if Newtonsoft version matches.
erdembayar 642229a
Try different pacakge for unit test.
erdembayar 8d705f5
Test
erdembayar e56ad1c
Address comment about foreach loop variable name.
erdembayar a0525f3
Remove 'parallel' word from comment. Because actual parallel code is …
erdembayar 2f42ca4
PackageReference/SDK style unit tests start working.
erdembayar c8c80c3
Making source works for unit tests.
erdembayar d0cd1f7
Fixed problem of Unit test project not picking up my custom PackageSo…
erdembayar ba98238
Revert LegacyPackageReferenceProject related changes, maybe I don't n…
erdembayar 026fc78
Git clean up and fix added unit tests with new PackSource logic.
erdembayar db37312
Fix typo.
erdembayar 3e37a97
Add NU1065 and new PackageSource handling to some unit test I forgot …
erdembayar 6cb39e0
Fix formatting recommendation in code review.
erdembayar 5e9b137
Remove parallel wording from method comment, because actual paralleli…
erdembayar ec71170
Fix typo.
erdembayar 084c67b
Refactor code after Andy's code review.
erdembayar 45b7488
Fix small typo.
erdembayar 722f9a8
After refactoring code PreviewBuildIntegratedProjectActionsAsync and …
erdembayar c08c972
All PreviewProjectsInstallPackageAsync related unit test for NugetPac…
erdembayar de5ea18
Remove the spaces and correct comments.
erdembayar 0adfabc
Revert changes to BuildIntegratedTests.cs since we already ported all…
erdembayar eedff34
Fix typo.
erdembayar 3d64f5e
Revert changes to LegacyPackageReferenceProjectTests.cs
erdembayar 1607bee
Revert back unneeded changes to NuGetPackageManagerTests.cs
erdembayar d214833
Remove unneeded change.
erdembayar 1907b16
Merge branch 'dev' into dev-eryondon-PMUIslowBecauseRestorerunsforEve…
erdembayar 75d0698
Add missing copy right notice for new file GetPackageReferenceUtility.cs
erdembayar 2e476cc
Add missing copyright notice for ProjectInstalledPackages.cs
erdembayar 69d269a
Merge branch 'dev' into dev-eryondon-PMUIslowBecauseRestorerunsforEve…
erdembayar 72229ab
Remove wrong file.
erdembayar 409b26a
Revert unneeded changes.
erdembayar 0f86276
Fix typos.
erdembayar 68b9140
Address code review comments and clean up.
erdembayar 8b24b6c
Merge branch 'dev' into dev-eryondon-PMUIslowBecauseRestorerunsforEve…
erdembayar 8344ca5
Now also remembers we evaluated the parents too.
erdembayar d6f3edf
Rename method name after nkolve92 code review.
erdembayar 7b33158
Address Nikolche code review comment about parent projects.
erdembayar 17c2ba9
Remove method PreviewResolveActionsForBuildIntegratedProjectsAsync me…
erdembayar a92df00
Make sure restore happens only once during uninstall process for chai…
erdembayar 530be92
Changed install package to all projects that it check for restore onl…
erdembayar a40bc7c
Merge branch 'dev' into dev-eryondon-PMUIslowBecauseRestorerunsforEve…
erdembayar 849007c
Clean up unused items.
erdembayar ae86fc7
Replace StringComparer.OrdinalIgnoreCase with PathUtility.GetStringCo…
erdembayar 8cd63ed
Refactor the unit tests after Nikolche's code review.
erdembayar 1d4dba6
Change unit test names.
erdembayar b4d3e69
Fix formatting.
erdembayar 24c713c
Fix with dot net formatting.
erdembayar 2d0c603
Add comment why we're separating BuildIntegratedNuGetProject vs packa…
erdembayar ccaecf6
Address more code review comments by Cristina.
erdembayar 1c55d8b
Merge branch 'dev' into dev-eryondon-PMUIslowBecauseRestorerunsforEve…
erdembayar ecc523d
Address Svet's code review comment.
erdembayar 20642c0
Fix formatting.
erdembayar 55c4b8d
Address Andy's latest code review.
erdembayar daedbef
Refactor unit test after Andy's code review.
erdembayar 4172d13
Fix unit test after Nikolche review.
erdembayar 736fd8b
Merge branch 'dev' into dev-eryondon-PMUIslowBecauseRestorerunsforEve…
erdembayar c563093
Fix formatting.
erdembayar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.