Unblock CI pipeline, component detection failure newtonsoft.json 4.0.1 #4934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
changed the title
zivkan
approved these changes
Nov 17, 2022
Member
zivkan
left a comment
zivkan
left a comment
There was a problem hiding this comment.
I had no idea that this feature existed.
I have no idea why this feature exists 🤦
jeffkl
approved these changes
Nov 17, 2022
erdembayar
deleted the
dev-eryondon-skip-end2end-test-InstallPackagesConfigOnline
branch
erdembayar
added a commit
that referenced
this pull request
Nov 22, 2022
erdembayar
added a commit
that referenced
this pull request
Nov 23, 2022
erdembayar
added a commit
that referenced
this pull request
Nov 23, 2022
erdembayar
added a commit
that referenced
this pull request
Nov 23, 2022
erdembayar
added a commit
that referenced
this pull request
Nov 23, 2022
erdembayar
added a commit
that referenced
this pull request
Dec 6, 2022
nkolev92
pushed a commit
that referenced
this pull request
Sep 29, 2023
nkolev92
pushed a commit
that referenced
this pull request
Sep 29, 2023
nkolev92
pushed a commit
that referenced
this pull request
Sep 29, 2023
nkolev92
added a commit
that referenced
this pull request
Oct 2, 2023
* Update dependencies in E2E tests (#4767) * Fix component detection alert for microsoft.owin package (#4841) * Remove package for Microsoft.Owin in End2end test * Address component detection failure newtonsoft.json 4.0.1 (#4934) * remove unused Moq package from E2E test (#5358) --------- Co-authored-by: Heng Liu <[email protected]> Co-authored-by: Erick Yondon <[email protected]> Co-authored-by: Martin Ruiz <[email protected]>
nkolev92
added a commit
that referenced
this pull request
Oct 2, 2023
* Update dependencies in E2E tests (#4767) * Fix component detection alert for microsoft.owin package (#4841) * Remove package for Microsoft.Owin in End2end test * Address component detection failure newtonsoft.json 4.0.1 (#4934) * remove unused Moq package from E2E test (#5358) * Use net6.0-windows --------- Co-authored-by: Heng Liu <[email protected]> Co-authored-by: Erick Yondon <[email protected]> Co-authored-by: Martin Ruiz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2024
Regression? Last working version:
Description
Newtonsoft.Json 4.0.1 dependency alert keep failing on official pipeline.
It's block issue. #1, #2, #3 .. etc
Currently End2end test
Test-InstallPackagesConfigOnline's pointing to 3rd party content https://raw.githubusercontent.com/NuGet/json-ld.net/7dc9becb263a7210ebcd2f571c2a7a07409c240a/src/JsonLD/packages.config, hence fixing test complicated, need more flexible solution. Until then need to skip it.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation