Remove unused Moq package from E2E #5358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinrrm
changed the title
jeffkl
approved these changes
Aug 14, 2023
aortiz-msft
requested changes
Aug 15, 2023
| function Test-TabExpansionForVersionForUninstallPackage { | ||
| # Arrange | ||
| $p = New-WebApplication | ||
| $p | Install-Package elmah -Version 1.1 |
Contributor
There was a problem hiding this comment.
Could we use this opportunity to move all our tests to .NET or Azure SDK packages?
Contributor
Author
There was a problem hiding this comment.
Just looked at "elmah" package and its being used 156 times in all kind of files, even in commmand line outputs 😨
Maybe that task is big and we will need to create another task for that, I suggest fixing this asap first
Contributor
There was a problem hiding this comment.
Could you please create an issue to track that?
Contributor
Author
There was a problem hiding this comment.
@aortiz-msft Created the issue in https://github.com/NuGet/Client.Engineering/issues/2434.
aortiz-msft
approved these changes
Aug 16, 2023
| function Test-TabExpansionForVersionForUninstallPackage { | ||
| # Arrange | ||
| $p = New-WebApplication | ||
| $p | Install-Package elmah -Version 1.1 |
Contributor
There was a problem hiding this comment.
Could you please create an issue to track that?
8 tasks
nkolev92
pushed a commit
that referenced
this pull request
Sep 29, 2023
nkolev92
pushed a commit
that referenced
this pull request
Sep 29, 2023
nkolev92
added a commit
that referenced
this pull request
Oct 2, 2023
* Update dependencies in E2E tests (#4767) * Fix component detection alert for microsoft.owin package (#4841) * Remove package for Microsoft.Owin in End2end test * Address component detection failure newtonsoft.json 4.0.1 (#4934) * remove unused Moq package from E2E test (#5358) --------- Co-authored-by: Heng Liu <[email protected]> Co-authored-by: Erick Yondon <[email protected]> Co-authored-by: Martin Ruiz <[email protected]>
nkolev92
added a commit
that referenced
this pull request
Oct 2, 2023
* Update dependencies in E2E tests (#4767) * Fix component detection alert for microsoft.owin package (#4841) * Remove package for Microsoft.Owin in End2end test * Address component detection failure newtonsoft.json 4.0.1 (#4934) * remove unused Moq package from E2E test (#5358) * Use net6.0-windows --------- Co-authored-by: Heng Liu <[email protected]> Co-authored-by: Erick Yondon <[email protected]> Co-authored-by: Martin Ruiz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2430
Regression? Last working version:
Description
Removes unused Moq reference in E2E test
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation