-
-
Notifications
You must be signed in to change notification settings - Fork 398
#131 Fix the missing link #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry about this. Realized it just after merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, of course, I should have noticed this as well
you are also reinstating the moved/deleted file docs/en/04-design/02-web-app-checklist/01-define-security-requirements.md
?
this makes sense for backward compatibility with the community's bookmarks etc, but also might confuse in future?
Happy with either path you choose, of course 👍🏾
The link checker is checking the release version, not the pull-request version, which is probably a flaw in the automation |
@jgadsden please go ahead and raise the issue. :D |
@jgadsden Is there a process for deprecation? We could point the user to the new version from the old page? |
that is a very good point https://github.com/OWASP/www-project-developer-guide/tree/main/release and to automatically redirect we use front matter such as for
|
so it would be good to redirect for pages that have been moved or deleted - over to you for the honour of raising the issue @sydseter ? |
Summary :
Fixes #131
Description for the changelog :
Fix missing link
Declaration:
Other info :
Thanks for submitting a pull request!
Please make sure you follow our Code of Conduct
and our contributing guidelines
Automated tests are run to check links, markdown and spelling
The pull request must pass these tests before it can be merged