Skip to content

Conversation

@ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Jan 1, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR is a step to refactor InlineModelResolver, updates only test codes to address warnings by IntelliJ IDEA.

Previous PR: #1786

@ackintosh ackintosh added this to the 4.0.0 milestone Jan 1, 2019
@ackintosh ackintosh merged commit 9334dd3 into OpenAPITools:master Jan 1, 2019
@ackintosh ackintosh deleted the tweak-testcase-for-inline-model-resolver branch January 1, 2019 04:14
@ackintosh ackintosh mentioned this pull request Jan 1, 2019
4 tasks
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Delete unnecessary "throws"

* Delete unnecessary cast expressions

* Tweak redundant assertions

* Delete unnecessary comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant