Refactor InlineModelResolver #1788
Merged
+307
−246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @OpenAPITools/generator-core-team |
jimschubert
approved these changes
Jan 1, 2019
Member
jimschubert
left a comment
jimschubert
left a comment
There was a problem hiding this comment.
This refactor looks good. I've never touched this file, so I'll let someone else merge. But the refactor seems easier to read, and I don't immediately notice any changes in logic.
wing328
reviewed
Jan 2, 2019
| openAPI.getComponents().addSchemas(modelName, model); | ||
| } | ||
| } | ||
| } else if (model instanceof ArraySchema) { |
Member
There was a problem hiding this comment.
Later we may need to do the same for MapSchema as well (not in this PR)
Contributor
Author
There was a problem hiding this comment.
Thanks for the comment, I'm working on the issue. 💨
wing328
approved these changes
Jan 2, 2019
Member
wing328
left a comment
wing328
left a comment
There was a problem hiding this comment.
Thanks for the refactoring, which looks good to me. The refactored code definitely looks a lot cleaner and better organized.
4 tasks
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Extract a method "flattenPaths" to reduce the scope of method * Tweak * Rename parameter name * Extract a method "flattenModels" to reduce the scope of method * Rename parameter name * Rename: models -> components * Delete comment * Extract a method "flattenRequestBody" to reduce the scope of method * Extract a method "flattenParameters" to reduce the scope of method * Extract a method "flattenResponses" to reduce the scope of method * Tweak types * Reduce indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
This PR is a step to refactor InlineModelResolver, extracts some methods from
flatten()to reduce scope of variables.Previous PR: #1787