Skip to content

[aspnetcore] Feature/cleanup (contributor rebase) #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimschubert merged 16 commits into from
Apr 2, 2019
Merged

[aspnetcore] Feature/cleanup (contributor rebase) #2506

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8b88ad3
Add optValue to CliOption
A-Joshi Mar 18, 2019
7c0e560
Use CliOption for classModifier, operationModifier, buildTarget, add …
A-Joshi Mar 18, 2019
d9ce202
Make abstract method look cleaner
A-Joshi Mar 18, 2019
99122e1
Add ASP.Net core 2.2
A-Joshi Mar 18, 2019
5774317
update docs
A-Joshi Mar 18, 2019
7b5c896
Reformat code to meet PR feedback
A-Joshi Mar 19, 2019
43aaf9c
Fix compilation with ASP.Net Core 2.1
A-Joshi Mar 19, 2019
b005e98
Update docs
A-Joshi Mar 19, 2019
d0de0de
Add optValue to CliOption
A-Joshi Mar 18, 2019
752e2e7
Add ASP.Net core 2.2
A-Joshi Mar 18, 2019
e60da35
Fix build target error
A-Joshi Mar 20, 2019
7205daf
Remove duplicated code
A-Joshi Mar 20, 2019
4616900
Fix Startup.cs whitespace
jimschubert Mar 25, 2019
6db3a78
[aspnetcore] Regenerate sample
jimschubert Mar 25, 2019
737d112
Fix wrong item in null check for cliOption
jimschubert Apr 1, 2019
9844afa
Merge branch 'master' into ihsmarkitoss-feature/cleanup
jimschubert Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix build target error
  • Loading branch information
@A-Joshi @jimschubert
A-Joshi authored and jimschubert committed Mar 25, 2019
commit e60da35390f30bcb05406e8c53a4b08d396c6471
2 changes: 1 addition & 1 deletion ...i-generator/src/main/java/org/openapitools/codegen/languages/AspNetCoreServerCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ private void setOperationModifier() {
private boolean setBuildTarget() {
boolean isLibrary = false;
setCliOption(buildTarget);
if ("library".equals(buildTarget)) {
if ("library".equals(buildTarget.getOptValue())) {
isLibrary = true;
projectSdk = SDK_LIB;
additionalProperties.put(CLASS_MODIFIER, "abstract");
Expand Down