[aspnetcore] Feature/cleanup (contributor rebase) #2506

jimschubert · 2019-03-26T02:40:28Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: master~~, 3.4.x, 4.0.x~~. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This is a rebase of #2436. Refer to that PR for discussion. This is work toward cleanup defined in #2285.

/cc @A-Joshi for visibility

…ASP.Net core 2.2

A-Joshi · 2019-03-26T21:38:01Z

...napi-generator/src/main/java/org/openapitools/codegen/languages/AspNetCoreServerCodegen.java

+    private void  setCliOption(CliOption cliOption) throws IllegalArgumentException {
+        if (additionalProperties.containsKey(cliOption.getOpt())) {
+            cliOption.setOptValue(additionalProperties.get(cliOption.getOpt()).toString());
+            if (classModifier.getOptValue() == null) {


Copy paste error - line should have cliOption.getOptValue not classModifier.getOptvalue

A-Joshi · 2019-03-31T10:55:27Z

Back from my travels, looks good except for one cut/paste error (I have commented on the PR). When can t be merged? I have more changes to support Async

…

On 3/25/19 10:40 PM, auto-labeler[bot] wrote: 👍 Thanks for opening this issue! 🏷 I have applied any labels matching special text in your issue. The team will review the labels and make any necessary changes. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2506 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANQEIQyUQ5UxRJ1MPJOfk4BZVzfvlJQ5ks5vaYijgaJpZM4cKeQX>.

@karismann

* master: (48 commits) [Typescript AngularJS] fix Extra package prefix in api parameters operations (OpenAPITools#2522) OpenAPITools#1023 - [Scala] Use status family during response processing (OpenAPITools#1024) Generate setters for readonly properties in server code (OpenAPITools#1582) [JS] fix NPE for null string and improve Travis config file (OpenAPITools#2553) [elm] Update ISO 8601 library (fixes missing time zone designator) (OpenAPITools#2545) [csharp] update sample after OpenAPITools#2528 (OpenAPITools#2550) [JavaScript] fix index.js, ApiClient.js and test files generated to incorrect location (OpenAPITools#2511) Aspnetcore nullable support (OpenAPITools#2529) Csharp nullable support (OpenAPITools#2528) [C++] [Qt5] Add enum support for client and server (OpenAPITools#2339) Fixed typo in migration-from-swagger-codegen.md (OpenAPITools#2548) [TypeScript Client] fix install Aurelia + fix use deprecated function (OpenAPITools#2514) [KOTLIN] fix var name not correctly sanitized (OpenAPITools#2537) Update swagger-parser to '2.0.11-OpenAPITools.org-1' (OpenAPITools#2262) Add @karismann to Java and Kotlin technical committee (OpenAPITools#2542) Add GoDaddy to the list of companies using OpenAPI Generator (OpenAPITools#2541) [Kotlin SpringBoot Server] alternative: fix optional parameter not correctly declared in service (OpenAPITools#2539) improve indentation, update dependencies (OpenAPITools#2521) update kotlin spring samples [JAVA] Use specified data type in enum's fromValue instead of string (OpenAPITools#2347) ...

jimschubert · 2019-04-01T03:47:11Z

Merging master into this branch locally, and regenerating the sample produces invalid annotations. Example:

         /// <summary>
         /// User Status
         /// </summary>
         /// <value>User Status</value>
-        [DataMember(Name="userStatus")]
+        [DataMember(Name="userStatus", EmitDefaultValue=)]
         public int? UserStatus { get; set; }

@wing328 do you know of a recent change which would have caused this?

I'm also seeing a warning and error dump when running the sample script. Possibly related?

$ ./bin/aspnetcore-petstore-server.sh
# START SCRIPT: ./bin/aspnetcore-petstore-server.sh
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was removed in 8.0
[main] WARN  i.s.parser.util.DeserializationUtils - Error snake-parsing yaml content
io.swagger.parser.util.DeserializationUtils$SnakeException: Exception safe-checking yaml content  (maxDepth 2000)
	at io.swagger.parser.util.DeserializationUtils$CustomSnakeYamlConstructor.getSingleData(DeserializationUtils.java:300)
	at org.yaml.snakeyaml.Yaml.loadFromReader(Yaml.java:450)
	at org.yaml.snakeyaml.Yaml.load(Yaml.java:369)
	at io.swagger.parser.util.DeserializationUtils.readYamlTree(DeserializationUtils.java:137)
	at io.swagger.parser.Swagger20Parser.deserializeYaml(Swagger20Parser.java:83)
	at io.swagger.parser.Swagger20Parser.readWithInfo(Swagger20Parser.java:64)
	at io.swagger.parser.SwaggerParser.readWithInfo(SwaggerParser.java:32)
	at io.swagger.v3.parser.converter.SwaggerConverter.readLocation(SwaggerConverter.java:92)
	at io.swagger.parser.OpenAPIParser.readLocation(OpenAPIParser.java:19)
	at org.openapitools.codegen.config.CodegenConfigurator.toClientOptInput(CodegenConfigurator.java:606)
	at org.openapitools.codegen.cmd.Generate.run(Generate.java:367)
	at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:60)
Caused by: java.lang.IllegalAccessError: tried to access field org.yaml.snakeyaml.constructor.BaseConstructor.composer from class io.swagger.parser.util.DeserializationUtils$CustomSnakeYamlConstructor
	at io.swagger.parser.util.DeserializationUtils$CustomSnakeYamlConstructor.getSingleData(DeserializationUtils.java:279)
	... 11 common frames omitted
[main] WARN  o.o.codegen.utils.ModelUtils - Multiple schemas found in content, returning only the first one
[main] WARN  o.o.codegen.utils.ModelUtils - Multiple schemas found in content, returning only the first one
[main] WARN  o.o.codegen.utils.ModelUtils - Multiple schemas found in content, returning only the first one

wing328 · 2019-04-01T03:50:01Z

[main] WARN i.s.parser.util.DeserializationUtils - Error snake-parsing yaml content

I noticed that too after the parser upgrade.

wing328 · 2019-04-01T05:43:04Z

@wing328 do you know of a recent change which would have caused this?

I also notice that in the latest master and I think I know why. Let me try to fix it later today.

wing328 · 2019-04-01T07:57:41Z

@wing328 do you know of a recent change which would have caused this?

The issue has been fixed via #2558

I'll file another PR to decommission the emitDefaultValue option as it should be controlled by the nullable attribute instead.

wing328 · 2019-04-01T08:36:14Z

FYI. Filed #2559 to remove the emitDefaultValue option.

A-Joshi · 2019-04-01T18:12:05Z

Looks like it passed all the checks - merge to master hopefully!

…

On 4/1/19 4:36 AM, William Cheng wrote: FYI. Filed #2559 <#2559> to remove the |emitDefaultValue| option. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2506 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANQEISfTbvNqAP2sjZb5yEA2gz7U0Nmqks5vccUCgaJpZM4cKeQX>.

jimschubert · 2019-04-02T01:08:36Z

@A-Joshi merged. This should unblock you for any additional work you'd had planned.

A-Joshi and others added 14 commits March 24, 2019 23:22

Add optValue to CliOption

8b88ad3

Use CliOption for classModifier, operationModifier, buildTarget, add …

7c0e560

…ASP.Net core 2.2

Make abstract method look cleaner

d9ce202

Add ASP.Net core 2.2

99122e1

update docs

5774317

Reformat code to meet PR feedback

7b5c896

Fix compilation with ASP.Net Core 2.1

43aaf9c

Update docs

b005e98

Add optValue to CliOption

d0de0de

Add ASP.Net core 2.2

752e2e7

Fix build target error

e60da35

Remove duplicated code

7205daf

Fix Startup.cs whitespace

4616900

[aspnetcore] Regenerate sample

6db3a78

jimschubert added the Server: C-Sharp label Mar 26, 2019

OpenAPITools deleted a comment from auto-labeler bot Mar 26, 2019

jimschubert mentioned this pull request Mar 26, 2019

[aspnetcore] Feature/cleanup #2436

Closed

4 tasks

A-Joshi reviewed Mar 26, 2019

View reviewed changes

wing328 added the Enhancement: General label Mar 27, 2019

wing328 added this to the 4.0.0 milestone Mar 27, 2019

jimschubert self-assigned this Mar 30, 2019

jimschubert added 2 commits March 31, 2019 21:58

Fix wrong item in null check for cliOption

737d112

jimschubert merged commit 128da8e into OpenAPITools:master Apr 2, 2019

jimschubert deleted the ihsmarkitoss-feature/cleanup branch April 2, 2019 01:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[aspnetcore] Feature/cleanup (contributor rebase) #2506

[aspnetcore] Feature/cleanup (contributor rebase) #2506

Uh oh!

jimschubert commented Mar 26, 2019 •

edited

Loading

Uh oh!

A-Joshi Mar 26, 2019

Uh oh!

A-Joshi commented Mar 31, 2019 via email

Uh oh!

jimschubert commented Apr 1, 2019

Uh oh!

wing328 commented Apr 1, 2019

Uh oh!

wing328 commented Apr 1, 2019

Uh oh!

wing328 commented Apr 1, 2019

Uh oh!

wing328 commented Apr 1, 2019

Uh oh!

A-Joshi commented Apr 1, 2019 via email

Uh oh!

jimschubert commented Apr 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

[aspnetcore] Feature/cleanup (contributor rebase) #2506

[aspnetcore] Feature/cleanup (contributor rebase) #2506

Uh oh!

Conversation

jimschubert commented Mar 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Description of the PR

Uh oh!

A-Joshi Mar 26, 2019

Choose a reason for hiding this comment

Uh oh!

A-Joshi commented Mar 31, 2019 via email

Uh oh!

jimschubert commented Apr 1, 2019

Uh oh!

wing328 commented Apr 1, 2019

Uh oh!

wing328 commented Apr 1, 2019

Uh oh!

wing328 commented Apr 1, 2019

Uh oh!

wing328 commented Apr 1, 2019

Uh oh!

A-Joshi commented Apr 1, 2019 via email

Uh oh!

jimschubert commented Apr 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jimschubert commented Mar 26, 2019 •

edited

Loading