[typescript-rxjs] Prints out the parameter name in throwIfNullOrUndefined #6083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
5 tasks
Member
|
cc @denyo |
Contributor
Author
|
@wing328 why the close? |
Member
|
Ping @wing328 |
Contributor
|
Possibly because the 5.0.x branch has been deleted? Is there a cut-off for the 5.0.x release? |
Member
|
@jtvd78 please open a new PR against master |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
throwIfNullOrUndefinedto take in & print the name of the parameter being checked. This PR in response to this comment here.The signature of
throwIfNulllOrUndefinedwas changed to makenicknamenon-optional, but based onapis.mustachethe param will never be undefined. Granted, the change is breaking, but this is also merging into 5.0.x. I considered removing the other deprecated exports inruntime.mustache(since this is merging into 5.0.x), but I figured I would not in this PR and ask for opinions about that here.PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)