Typescript-rxjs: print param name #6368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
amakhrov
approved these changes
May 19, 2020
Contributor
amakhrov
left a comment
amakhrov
left a comment
There was a problem hiding this comment.
Thanks for the PR - looks good to me
TiFu
approved these changes
May 21, 2020
Contributor
There was a problem hiding this comment.
Thanks for the PR! LGTM too.
Circle-CI failure is unrelated and caused by issues with the Dart generator.
No idea what's going on with Shippable, I can't even find the download button... Will close & reopen this PR to trigger Shippable again - let's see if that fixes the issue.
Member
|
@jtvd78 can you please merge the most recent master into your branch? |
jimschubert
added a commit
that referenced
this pull request
Jun 3, 2020
* master: [Go][Experimental] Fix discriminator lookup (#6521) Typescript-rxjs: print param name (#6368) add oneof discrimistrator lookup to go experimental (#6517) [PowerShell] Add useOneOfDiscriminatorLookup option (#6516) add discriminator support to anyOf powershell client (#6512) [Go][Experimental] Add discriminator support to anyOf (#6511)
jimschubert
added a commit
that referenced
this pull request
Jun 5, 2020
* master: (345 commits) [kotlin][spring] Fix ApiUtil compilation (#6084) update python samples [Python] Fixed docstrings in api.mustache (#6391) [BUG][python] Support named arrays (#6493) [Go] whitelist AdditionalProperties in the field name (#6543) [kotlin][client] remove tabs usage (#6526) [PS] automatically derive discriminator mapping for oneOf/anyOf (#6542) [C++][Ue4] various bus fixes (#6539) Fix incorrect npx command (#6537) update pester to 5.x (#6536) comment out openapi3 java jersey2-java8 tests add additional properties support to powershell client generator (#6528) [Go][Experimental] Support additionalProperties (#6525) #5476 [kotlin] [spring] fix swagger and spring annotation for defaultValue (#6101) [samples] regenerate (#6533) [python] Fix date-time parsing (#6458) Register OAuth2ClientContext as bean (#6172) [Go][Experimental] Fix discriminator lookup (#6521) Typescript-rxjs: print param name (#6368) add oneof discrimistrator lookup to go experimental (#6517) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
throwIfNullOrUndefinedto take in & print the name of the parameter being checked. This PR in response to this comment here.The signature of
throwIfNulllOrUndefinedwas changed to makenicknamenon-optional, but based onapis.mustachethe param will never be undefined. Granted, the change is breaking, but this is also merging into 5.0.x. I considered removing the other deprecated exports inruntime.mustache(since this is merging into 5.0.x), but I figured I would not in this PR and ask for opinions about that here.PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)