Skip to content

Increase test coverage #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 9 commits into from
Aug 24, 2018
Merged

Increase test coverage #1237

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
991d0ee
Fixed a SplitPayment test
nventuro Aug 24, 2018
1573086
Deleted unnecessary function.
nventuro Aug 24, 2018
22788d9
Improved PostDeliveryCrowdsale tests.
nventuro Aug 24, 2018
aeb5407
Improved RefundableCrowdsale tests.
nventuro Aug 24, 2018
ba02ab0
Improved MintedCrowdsale tests.
nventuro Aug 24, 2018
193a506
Improved IncreasingPriceCrowdsale tests.
nventuro Aug 24, 2018
12f4420
Fixed a CappedCrowdsale test.
nventuro Aug 24, 2018
5b0d148
Improved TimedCrowdsale tests.
nventuro Aug 24, 2018
33a6c5d
Improved descriptions of added tests.
nventuro Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 70 additions & 40 deletions test/crowdsale/RefundableCrowdsale.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,56 +30,86 @@ contract('RefundableCrowdsale', function ([_, owner, wallet, investor, purchaser
this.openingTime = (await latestTime()) + duration.weeks(1);
this.closingTime = this.openingTime + duration.weeks(1);
this.afterClosingTime = this.closingTime + duration.seconds(1);
this.preWalletBalance = await ethGetBalance(wallet);

this.token = await SimpleToken.new();
this.crowdsale = await RefundableCrowdsale.new(
this.openingTime, this.closingTime, rate, wallet, this.token.address, goal, { from: owner }
});

it('it requires a non-zero goal', async function () {
await expectThrow(
RefundableCrowdsale.new(
this.openingTime, this.closingTime, rate, wallet, this.token.address, 0, { from: owner }
Copy link
Contributor

@frangio frangio Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests would be a lot clearer if we had a helper like newRefundableCrowdsale({ goal: 0}) that just used the default values for everything else.

),
EVMRevert,
);
await this.token.transfer(this.crowdsale.address, tokenSupply);
});

describe('creating a valid crowdsale', function () {
it('should fail with zero goal', async function () {
await expectThrow(
RefundableCrowdsale.new(
this.openingTime, this.closingTime, rate, wallet, this.token.address, 0, { from: owner }
),
EVMRevert,
context('with crowdsale', function () {
beforeEach(async function () {
this.crowdsale = await RefundableCrowdsale.new(
this.openingTime, this.closingTime, rate, wallet, this.token.address, goal, { from: owner }
);

await this.token.transfer(this.crowdsale.address, tokenSupply);
});
});

it('should deny refunds before end', async function () {
await expectThrow(this.crowdsale.claimRefund({ from: investor }), EVMRevert);
await increaseTimeTo(this.openingTime);
await expectThrow(this.crowdsale.claimRefund({ from: investor }), EVMRevert);
});
context('before opening time', function () {
it('should deny refunds', async function () {
await expectThrow(this.crowdsale.claimRefund({ from: investor }), EVMRevert);
});

it('should deny refunds after end if goal was reached', async function () {
await increaseTimeTo(this.openingTime);
await this.crowdsale.sendTransaction({ value: goal, from: investor });
await increaseTimeTo(this.afterClosingTime);
await expectThrow(this.crowdsale.claimRefund({ from: investor }), EVMRevert);
});
});

it('should allow refunds after end if goal was not reached', async function () {
await increaseTimeTo(this.openingTime);
await this.crowdsale.sendTransaction({ value: lessThanGoal, from: investor });
await increaseTimeTo(this.afterClosingTime);
await this.crowdsale.finalize({ from: owner });
const pre = await ethGetBalance(investor);
await this.crowdsale.claimRefund({ from: investor, gasPrice: 0 });
const post = await ethGetBalance(investor);
post.minus(pre).should.be.bignumber.equal(lessThanGoal);
});
context('after opening time', function () {
beforeEach(async function () {
await increaseTimeTo(this.openingTime);
});

it('should forward funds to wallet after end if goal was reached', async function () {
await increaseTimeTo(this.openingTime);
await this.crowdsale.sendTransaction({ value: goal, from: investor });
await increaseTimeTo(this.afterClosingTime);
const pre = await ethGetBalance(wallet);
await this.crowdsale.finalize({ from: owner });
const post = await ethGetBalance(wallet);
post.minus(pre).should.be.bignumber.equal(goal);
it('should deny refunds', async function () {
await expectThrow(this.crowdsale.claimRefund({ from: investor }), EVMRevert);
});

context('with unreached goal', function () {
beforeEach(async function () {
await this.crowdsale.sendTransaction({ value: lessThanGoal, from: investor });
});

context('after closing time and finalization', function () {
beforeEach(async function () {
await increaseTimeTo(this.afterClosingTime);
await this.crowdsale.finalize({ from: owner });
});

it('should refund', async function () {
const pre = await ethGetBalance(investor);
await this.crowdsale.claimRefund({ from: investor, gasPrice: 0 });
const post = await ethGetBalance(investor);
post.minus(pre).should.be.bignumber.equal(lessThanGoal);
});
});
});

context('with reached goal', function () {
beforeEach(async function () {
await this.crowdsale.sendTransaction({ value: goal, from: investor });
});

context('after closing time and finalization', function () {
beforeEach(async function () {
await increaseTimeTo(this.afterClosingTime);
await this.crowdsale.finalize({ from: owner });
});

it('should deny refunds', async function () {
await expectThrow(this.crowdsale.claimRefund({ from: investor }), EVMRevert);
});

it('should forward funds to wallet', async function () {
const postWalletBalance = await ethGetBalance(wallet);
postWalletBalance.minus(this.preWalletBalance).should.be.bignumber.equal(goal);
});
});
});
});
});
});