-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Add validation in Governor on ERC-721 or ERC-1155 received #4314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
frangio
merged 15 commits into
OpenZeppelin:master
from
clauBv23:add-validation-in-governor-when-receive-erc721-erc1155
Jun 16, 2023
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
47402f9
add validation in governor receive hooks
clauBv23 fa17040
add test cases for governor receive hooks validations
clauBv23 40139a8
add changeset
clauBv23 38c4759
add revert message in governor timelock test
clauBv23 6a8d20f
change hooks comments for more descriptive ones
clauBv23 e13ef57
Merge branch 'master' into add-validation-in-governor-when-receive-er…
clauBv23 1c324a0
Merge branch 'master' into add-validation-in-governor-when-receive-er…
Amxx d07c900
Fix tests
Amxx 8e37c00
Bubble custom errors emitted in ERC1155Receiver hooks
Amxx 8a244e5
add changeset
Amxx e8370d5
fix lint
Amxx b930f65
Apply suggestions from code review
Amxx 34dd8c0
Update mighty-donuts-smile.md
frangio 40068a2
Update thin-camels-matter.md
frangio 2d53fa7
Update .changeset/thin-camels-matter.md
frangio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
add validation in governor receive hooks
- Loading branch information
commit 47402f9153cd16939c29a299ea78cc07c09caab3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.