Skip to content

Add validation in Governor on ERC-721 or ERC-1155 received #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 15 commits into from
Jun 16, 2023
Merged

Add validation in Governor on ERC-721 or ERC-1155 received #4314

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
47402f9
add validation in governor receive hooks
clauBv23 Jun 5, 2023
fa17040
add test cases for governor receive hooks validations
clauBv23 Jun 5, 2023
40139a8
add changeset
clauBv23 Jun 5, 2023
38c4759
add revert message in governor timelock test
clauBv23 Jun 5, 2023
6a8d20f
change hooks comments for more descriptive ones
clauBv23 Jun 6, 2023
e13ef57
Merge branch 'master' into add-validation-in-governor-when-receive-er…
clauBv23 Jun 6, 2023
1c324a0
Merge branch 'master' into add-validation-in-governor-when-receive-er…
Amxx Jun 14, 2023
d07c900
Fix tests
Amxx Jun 14, 2023
8e37c00
Bubble custom errors emitted in ERC1155Receiver hooks
Amxx Jun 14, 2023
8a244e5
add changeset
Amxx Jun 14, 2023
e8370d5
fix lint
Amxx Jun 14, 2023
b930f65
Apply suggestions from code review
Amxx Jun 14, 2023
34dd8c0
Update mighty-donuts-smile.md
frangio Jun 15, 2023
40068a2
Update thin-camels-matter.md
frangio Jun 15, 2023
2d53fa7
Update .changeset/thin-camels-matter.md
frangio Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Claudia Barcelo <[email protected]>
  • Loading branch information
@Amxx @clauBv23
Amxx and clauBv23 authored Jun 14, 2023
commit b930f65aed164090a15e5e6ffa6a2109a3467fbf
2 changes: 1 addition & 1 deletion test/token/ERC1155/ERC1155.behavior.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ function shouldBehaveLikeERC1155([minter, firstTokenHolder, secondTokenHolder, m
RevertType.None,
);

await expectRevert(
await expectRevertCustomError(
this.token.safeTransferFrom(multiTokenHolder, receiver.address, firstTokenId, firstAmount, '0x', {
from: multiTokenHolder,
}),
Expand Down