Skip to content

Conversation

@ernestognw
Copy link
Member

Fix an incorrect definition in the release cycle state file

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023

⚠️ No Changeset found

Latest commit: 9ee9ddb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you are doing the negation twice, and the outcome of shouldRunMerge is not modified. I there more to it that I'm missing ?

@ernestognw
Copy link
Member Author

ernestognw commented Jun 17, 2023

It looks like you are doing the negation twice, and the outcome of shouldRunMerge is not modified. I there more to it that I'm missing ?

That's correct. The variable is behaving as expected. It's just that its name is representing the opposite of what it should. We either do the double negation or change the variable name but I'd like to keep the naming since it makes it much easier to read each of the state functions imo

@Amxx
Copy link
Collaborator

Amxx commented Jun 19, 2023

I thought there was a behavior we wanted to change.

@ernestognw ernestognw changed the title Fix prBackExists variable Change release cycle prBackExists definition Jun 19, 2023
@ernestognw
Copy link
Member Author

I thought there was a behavior we wanted to change.

Good call anyway, I'm renaming the PR for more clarity

@frangio frangio merged commit fc19a79 into OpenZeppelin:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants