Skip to content

Change release cycle prBackExists definition #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 1 commit into from
Jun 19, 2023
Merged

Change release cycle prBackExists definition #4365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix prBackExists variable
  • Loading branch information
@ernestognw
ernestognw committed Jun 16, 2023
commit 9ee9ddb1c08292b37c72272e6093a632d4b5df0b
4 changes: 2 additions & 2 deletions scripts/release/workflow/state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function shouldRunMerge({
hasPendingChangesets,
prBackExists,
}) {
return isReleaseBranch && isPush && !prerelease && isCurrentFinalVersion && !hasPendingChangesets && prBackExists;
return isReleaseBranch && isPush && !prerelease && isCurrentFinalVersion && !hasPendingChangesets && !prBackExists;
}

async function getState({ github, context, core }) {
Expand Down Expand Up @@ -79,7 +79,7 @@ async function getState({ github, context, core }) {
state: 'open',
});

state.prBackExists = prs.length === 0;
state.prBackExists = prs.length !== 0;

state.isPublishedOnNpm = await isPublishedOnNpm(packageName, version);

Expand Down