Skip to content

Enable ERC-1271 signature checks in Governor castVoteBySig #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 7 commits into from
Jul 5, 2023
Merged

Enable ERC-1271 signature checks in Governor castVoteBySig #4418

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f95789f
Make Governor ERC-1271 compatible
ernestognw Jul 3, 2023
3c74d60
Improved test and docs
ernestognw Jul 3, 2023
351450b
Add changeset
ernestognw Jul 3, 2023
01cbd6c
Add another changeset
ernestognw Jul 3, 2023
c0fab29
Apply review suggestions
ernestognw Jul 4, 2023
89ba1a4
Changesets periods
ernestognw Jul 4, 2023
3b9dcd2
Merge changesets
ernestognw Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add another changeset
  • Loading branch information
@ernestognw
ernestognw committed Jul 3, 2023
commit 01cbd6c5a06c99c0e70e19d93cf54ab7e2ed9b6e
5 changes: 5 additions & 0 deletions .changeset/popular-deers-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'openzeppelin-solidity': major
---

`Governor`: Use `bytes memory` signature instead of `r`, `s` and `v` parameters in the `castVoteBySig` and `castVoteWithReasonAndParamsBySig` functions
Copy link
Contributor

@frangio frangio Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not merge the two changesets into one?

Copy link
Member Author

@ernestognw ernestognw Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thought both required their own entry. Although the main reason of this PR is to introduce 1271 compatibility, it requires this change that should be communicated on its own.

We can think of an individual changeset if you think it's needed

Copy link
Contributor

@frangio frangio Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intuition is that all of the changes to castVoteBySig should be together in the same changeset, including also #4378 currently in .changeset/sixty-numbers-reply.md.

If not that, I do think we should at least merge the 2 in this PR.

Copy link
Member Author

@ernestognw ernestognw Jul 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer merging these two into a single one because otherwise, we'll be breaking the PR reference when processing the changesets into the changelog.

Not sure if all the changes should be in a single entry. But I'd be worried about the order in the Changelog once they get processed.