Skip to content

Enable ERC-1271 signature checks in Governor castVoteBySig #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 7 commits into from
Jul 5, 2023
Merged

Enable ERC-1271 signature checks in Governor castVoteBySig #4418

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f95789f
Make Governor ERC-1271 compatible
ernestognw Jul 3, 2023
3c74d60
Improved test and docs
ernestognw Jul 3, 2023
351450b
Add changeset
ernestognw Jul 3, 2023
01cbd6c
Add another changeset
ernestognw Jul 3, 2023
c0fab29
Apply review suggestions
ernestognw Jul 4, 2023
89ba1a4
Changesets periods
ernestognw Jul 4, 2023
3b9dcd2
Merge changesets
ernestognw Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changesets periods 
Co-authored-by: Francisco <[email protected]>
  • Loading branch information
@ernestognw @frangio
ernestognw and frangio committed Jul 4, 2023
commit 89ba1a44ac0466cb401bbfd987899502eb73adf0
2 changes: 1 addition & 1 deletion .changeset/dry-crews-sell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
'openzeppelin-solidity': minor
---

`Governor`: Add support for casting votes with ERC-1271 signatures
`Governor`: Add support for casting votes with ERC-1271 signatures.
2 changes: 1 addition & 1 deletion .changeset/popular-deers-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
'openzeppelin-solidity': major
---

`Governor`: Use `bytes memory` signature instead of `r`, `s` and `v` parameters in the `castVoteBySig` and `castVoteWithReasonAndParamsBySig` functions
`Governor`: Use `bytes memory` signature instead of `r`, `s` and `v` parameters in the `castVoteBySig` and `castVoteWithReasonAndParamsBySig` functions.