Skip to content

Replace custom errors with native panic codes in DoubleEndedQueue #4872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 5 commits into from
Feb 6, 2024
Merged

Replace custom errors with native panic codes in DoubleEndedQueue #4872

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20ad305
Replace custom errors with native panic codes in DoubleEndedQueue
Amxx Feb 2, 2024
5a43ef4
lint
Amxx Feb 2, 2024
9027fb8
fix tests
Amxx Feb 2, 2024
eae2272
Add internal variables to docs
ernestognw Feb 6, 2024
16c52e5
Reference Panic library in DoubleEndedQueue
ernestognw Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@Amxx
Amxx committed Feb 2, 2024
commit 5a43ef4aed11aa4feac33a4442d9cccf73b05ec6
2 changes: 1 addition & 1 deletion contracts/utils/structs/DoubleEndedQueue.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// OpenZeppelin Contracts (last updated v5.0.0) (utils/structs/DoubleEndedQueue.sol)
pragma solidity ^0.8.20;

import { Panic } from "../Panic.sol";
import {Panic} from "../Panic.sol";

/**
* @dev A sequence of items with the ability to efficiently push and pop items (i.e. insert and remove) on both ends of
Expand Down
4 changes: 3 additions & 1 deletion test/utils/structs/DoubleEndedQueue.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ describe('DoubleEndedQueue', function () {
});

it('out of bounds access', async function () {
await expect(this.mock.$at(0, this.content.length)).to.be.revertedWithPanic(PANIC_CODES.ARRAY_ACCESS_OUT_OF_BOUNDS);
await expect(this.mock.$at(0, this.content.length)).to.be.revertedWithPanic(
PANIC_CODES.ARRAY_ACCESS_OUT_OF_BOUNDS,
);
});

describe('push', function () {
Expand Down