Skip to content

Bubble up returndata from reverted Create2 deployments #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 8 commits into from
May 27, 2024
Merged

Bubble up returndata from reverted Create2 deployments #5052

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fbcf8de
Update contract deployment to fix returndata ignoring
dimitriospapathanasiou May 22, 2024
446eb84
refactor revert bubble + testing
Amxx May 23, 2024
f31d3cc
Update Create2.sol
Amxx May 23, 2024
a45f786
up
ernestognw May 24, 2024
705d715
Fix upgradeable tests
ernestognw May 24, 2024
f51b439
Update .changeset/nervous-eyes-teach.md
ernestognw May 24, 2024
15e4aca
Merge branch 'master' into feature/fix-issue-#5046
ernestognw May 24, 2024
42fe09f
Merge branch 'master' into feature/fix-issue-#5046
Amxx May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
up
  • Loading branch information
@ernestognw
ernestognw committed May 24, 2024
commit a45f786a54734167c2300219f8fa6e6af4a775f7
8 changes: 4 additions & 4 deletions test/utils/Create2.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ describe('Create2', function () {
});

describe('reverts error thrown during contract creation', function () {
it('Revert without message', async function () {
it('bubbles up without message', async function () {
await expect(
this.factory.$deploy(
0n,
Expand All @@ -150,7 +150,7 @@ describe('Create2', function () {
).to.be.revertedWithCustomError(this.factory, 'FailedDeployment');
});

it('Revert with message', async function () {
it('bubbles up message', async function () {
await expect(
this.factory.$deploy(
0n,
Expand All @@ -163,7 +163,7 @@ describe('Create2', function () {
).to.be.revertedWith('ConstructorMock: reverting');
});

it('Revert with custom error', async function () {
it('bubbles up custom error', async function () {
await expect(
this.factory.$deploy(
0n,
Expand All @@ -176,7 +176,7 @@ describe('Create2', function () {
).to.be.revertedWithCustomError({ interface: this.mockFactory.interface }, 'CustomError');
});

it('Panic', async function () {
it('bubbles up panic', async function () {
await expect(
this.factory.$deploy(
0n,
Expand Down