-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Bubble up returndata from reverted Create2 deployments
#5052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Amxx
merged 8 commits into
OpenZeppelin:master
from
dimitriospapathanasiou:feature/fix-issue-#5046
May 27, 2024
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fbcf8de
Update contract deployment to fix returndata ignoring
dimitriospapathanasiou 446eb84
refactor revert bubble + testing
Amxx f31d3cc
Update Create2.sol
Amxx a45f786
up
ernestognw 705d715
Fix upgradeable tests
ernestognw f51b439
Update .changeset/nervous-eyes-teach.md
ernestognw 15e4aca
Merge branch 'master' into feature/fix-issue-#5046
ernestognw 42fe09f
Merge branch 'master' into feature/fix-issue-#5046
Amxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Update contract deployment to fix returndata ignoring
- Loading branch information
commit fbcf8decb3add5952a33e10f675c3ef9ad463e46
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'openzeppelin-solidity': minor | ||
| --- | ||
|
|
||
| `Create2`: Capture and Utilization of returndata from failed deployment | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.