Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc
  • Loading branch information
Amxx authored and cairoeth committed Jul 16, 2024
commit 28402a6277a3458ff844094fc06f9d3b17b19c80
9 changes: 9 additions & 0 deletions contracts/interfaces/draft-IERC7674.sol
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@

pragma solidity ^0.8.20;

/**
* @dev Temporary Approval Extension for ERC-20 (https://github.com/ethereum/ERCs/pull/358[ERC-7674])
*
* WARNING: This ERC is not final, and is likelly to evolve.
*/
interface IERC7674 {
/**
* @dev Set the temporary allowance, allowing allows `spender` to withdraw (within the same transaction) assets
* held by the caller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5071/files#diff-7b0f1795668241cd100ce0a5728fc598e10533cf7bd2846a8b5c86b8a7ac6fa5R60-R71 is much clearer imo. for consistency (and to not duplicate), shouldn't we have these comments in the interface, and point to the interface in the implementation function comments? as in here https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/ERC20.sol#L118

*/
function temporaryApprove(address spender, uint256 value) external returns (bool success);
}