Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
ernestognw authored and cairoeth committed Jul 16, 2024
commit 352f56c8a6139ed532378dc7ddde4c55aa7fa7a9
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ abstract contract ERC20TemporaryApproval is ERC20, IERC7674 {

/**
* @dev {_spendAllowance} override that consumes the temporary allowance (if any) before eventually falling back
* to consumming the persistent allowance.
* to consuming the persistent allowance.
*/
function _spendAllowance(address owner, address spender, uint256 value) internal virtual override {
// load transient allowance
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('ERC20TemporaryApproval', function () {
persistentAllowance: 17n,
},
{ description: 'support allowance overflow', temporaryAllowance: ethers.MaxUint256, persistentAllowance: 17n },
{ description: 'consumming temporary allowance alone', temporaryAllowance: 42n, amount: 2n },
{ description: 'consuming temporary allowance alone', temporaryAllowance: 42n, amount: 2n },
{
description: 'fallback to persistent allowance if temporary allowance is not sufficient',
temporaryAllowance: 42n,
Expand Down