Fix race condition in bounty test. #799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrugs
previously requested changes
Mar 12, 2018
test/Bounty.test.js
Outdated
| from: sender, | ||
| to: receiver, | ||
| value: value, | ||
| return new Promise(function (accept, reject) { |
Contributor
There was a problem hiding this comment.
please run npm run lint:all:fix — our linter rules will enforce that the arguments to the promise function are called resolve and reject
|
Hey @benjamincburns, can you please update this branch? |
shrugs
force-pushed
the
fix-bounty-test-race
branch
from
22fa664 to
0e1fc86
Compare
shrugs
added a commit
to shrugs/openzeppelin-solidity
that referenced
this pull request
Jul 25, 2018
Contributor
|
Superceded by #1112. |
nventuro
pushed a commit
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered when updating the test suite to use ganache-cli v6.1.0.