Update to ganache-cli v6.1.0 and truffle v4.1.0 #800
Conversation
|
|
||
| - Which version of OpenZeppelin are you using? | ||
| - What network are you deploying to? testrpc? Ganache? Ropsten? | ||
| - What network are you deploying to? ganache-cli? Ganache? Ropsten? |
There was a problem hiding this comment.
Can we change this to just say What network are you deploying to? Ganache? Rinkeby?
|
|
||
| before(async function () { | ||
| // Advance to the next block to correctly read time in the solidity "now" function interpreted by testrpc | ||
| // Advance to the next block to correctly read time in the solidity "now" function interpreted by ganache |
There was a problem hiding this comment.
So we've obviously copy-pasted these test files over and over again 😅 can we just remove these duplicate comments in all of these crowdsale tests? I could also see an argument for the extra verbosity being worth it.
| gasPrice: 0x01, | ||
| }, | ||
| testrpc: { | ||
| "ganache-cli": { |
There was a problem hiding this comment.
let's change this to just ganache?
| host: 'localhost', | ||
| port: 8545, | ||
| network_id: '*', // eslint-disable-line camelcase | ||
| network_id: '*' // eslint-disable-line camelcase |
There was a problem hiding this comment.
was this enforced by our eslint config or your editor? I think our eslint config enforces the trailing multiline comma
|
Hi @shrugs, just leaving a note here re: Happy to open a PR if that's helpful but there are no associated changes apart from the version number. |
|
Thanks for the note, @cgewecke! sounds like solidity-coverage should be fine as-is, then. |
4 participants
Updates the test suite to use
ganache-cliv6.1.0 instead ofethereumjs-testrpcv6.0.1, and to usetrufflev4.1.0 instead oftrufflev4.0.1.All tests pass locally when combined with #799.
Note that this test does not update anything to do with
testrpc-scas I don't control releases of that tool, however @cgewecke is aware of this change.Moved
truffle-config.jstotruffle.jsas this is the filename expected for the main truffle configuration now. Not having atruffle.jscaused me to run into ConsenSys-archive/truffle#838.