Re-readd root/admin user detection #6703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why run |
Contributor
|
Wondering if it'd be better to use available API as before, and if it returns root as user, then use the command to confirm it? |
Proximyst
suggested changes
Oct 2, 2021
Member
|
How common is it for servers to not contain the id binary? I'd question whether it's better to have it default to warning when it's missing - but guess it depends how often it's missing Logic being a host can easily fix it themselves if it shows up due to missing id binary |
lynxplay
requested changes
Oct 8, 2021
me4502
approved these changes
Oct 9, 2021
Proximyst
approved these changes
Oct 9, 2021
me4502
force-pushed
the
feature/re-readd-root-detection
branch
from
0d4e696 to
f988ac1
Compare
jcxldn
added a commit
to jcxldn/mcr
that referenced
this pull request
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-adds the root reverted in e8830b2. The check was throwing false positives because of a OpenJDk bug (no issue # yet, will add here later). This PR uses a different method for getting the UID (executing the id command), which isn't affected by the openjdk issue.