Skip to content

Conversation

@jasl
Copy link
Contributor

@jasl jasl commented Jan 19, 2023

paritytech/substrate@polkadot-v0.9.34...polkadot-v0.9.35
paritytech/substrate@polkadot-v0.9.35...polkadot-v0.9.36
paritytech/substrate@polkadot-v0.9.36...polkadot-v0.9.37

Breaking changes for us:

Special note for paritytech/substrate#12891 in the future, we have to write call_index for every extrinsic calls, or it will fail to compilation

Other notable changes:

TODO: These Subxt change breaks Pherry

@jasl jasl requested a review from kvinwang January 19, 2023 23:21
@jasl
Copy link
Contributor Author

jasl commented Jan 19, 2023

There's an error, relates to paritytech/substrate#12883

   Compiling pink v0.1.0 (/Users/jasl/Workspaces/BlockChain/phala-blockchain/crates/pink)
error[E0599]: the method `as_ref` exists for reference `&<<E as pallet_contracts::chain_extension::Ext>::T as SysConfig>::AccountId`, but its trait bounds were not satisfied
   --> crates/pink/src/runtime/extension.rs:105:14
    |
105 |             .as_ref()
    |              ^^^^^^ method cannot be called on `&<<E as pallet_contracts::chain_extension::Ext>::T as SysConfig>::AccountId` due to unsatisfied trait bounds
    |
    = note: the following trait bounds were not satisfied:
            `<<E as pallet_contracts::chain_extension::Ext>::T as SysConfig>::AccountId: AsRef<_>`
            which is required by `&<<E as pallet_contracts::chain_extension::Ext>::T as SysConfig>::AccountId: AsRef<_>`

For more information about this error, try `rustc --explain E0599`.

@jasl jasl marked this pull request as ready for review January 28, 2023 11:48
Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasl jasl merged commit a68fab5 into master Jan 29, 2023
@jasl jasl deleted the polkadot-v0.9.37 branch January 29, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants