`BlockId` removal: refactor: `HeaderBackend::header` #12874

michalkucharczyk · 2022-12-08T15:19:06Z

BlockId removal: refactor: HeaderBackend::header

It changes the arguments of:

HeaderBackend::header,
Client::header,
PeersClient::header
ChainApi::block_header

methods from: BlockId<Block> to: Block::Hash

This PR is part of BlockId::Number refactoring analysis (paritytech/polkadot-sdk#53)

polkadot companion: paritytech/polkadot#6418
cumulus companion: paritytech/cumulus#1977

It changes the arguments of: - `HeaderBackend::header`, - `Client::header`, - `PeersClient::header` - `ChainApi::block_header` methods from: `BlockId<Block>` to: `Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)

This may required introduction of dedicated function: header_for_block_num

lexnv

LGTM!

A couple of places where this needs changing:

substrate/client/basic-authorship/src/lib.rs

Lines 52 to 54 in e6bbc53

    
           //! let proposer = proposer_factory.init( 
        
           //! 	&client.header(&BlockId::number(0)).unwrap().unwrap(), 
        
           //! );

And the readme: https://github.com/paritytech/substrate/blob/master/client/basic-authorship/README.md

michalkucharczyk · 2022-12-12T18:17:21Z

bot rebase

…ackend-header

paritytech-processbot · 2022-12-12T18:17:28Z

Rebased

michalkucharczyk · 2022-12-12T19:23:24Z

/cmd queue -c fmt

command-bot · 2022-12-12T19:23:28Z

@michalkucharczyk https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2149145 was started for your command "$PIPELINE_SCRIPTS_DIR/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 57-ea246742-1cf7-4eb0-ae09-7efc095af177 to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot · 2022-12-12T19:24:40Z

@michalkucharczyk Command "$PIPELINE_SCRIPTS_DIR/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2149145 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2149145/artifacts/download.

…ackend-header

It changes the arguments of `HeaderBackend::expect_header` method from: `BlockId<Block>` to: `Block::Hash`

…ackend-header

michalkucharczyk · 2022-12-15T11:52:52Z

/cmd queue -c fmt

command-bot · 2022-12-15T11:52:55Z

@michalkucharczyk https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2161994 was started for your command "$PIPELINE_SCRIPTS_DIR/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 79-77b0824f-28ac-44e6-bb93-f67671da455f to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot · 2022-12-15T11:54:07Z

@michalkucharczyk Command "$PIPELINE_SCRIPTS_DIR/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2161994 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2161994/artifacts/download.

…ackend-header

michalkucharczyk · 2022-12-20T08:44:33Z

bot rebase

…ackend-header

paritytech-processbot · 2022-12-20T08:44:41Z

Rebased

michalkucharczyk · 2022-12-20T08:47:42Z

/cmd queue -c fmt

command-bot · 2022-12-20T08:47:46Z

@michalkucharczyk https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2177419 was started for your command "$PIPELINE_SCRIPTS_DIR/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 119-569a4ff9-fcb8-48e2-8c1b-71590e030703 to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot · 2022-12-20T08:48:58Z

@michalkucharczyk Command "$PIPELINE_SCRIPTS_DIR/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2177419 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2177419/artifacts/download.

michalkucharczyk · 2022-12-20T09:23:00Z

bot merge

paritytech-processbot · 2022-12-20T09:23:09Z

Error: Github API says paritytech/cumulus#1977 is not mergeable

michalkucharczyk · 2022-12-20T09:23:52Z

bot merge

paritytech-processbot · 2022-12-20T09:24:00Z

Error: Github API says paritytech/cumulus#1977 is not mergeable

michalkucharczyk · 2022-12-20T09:43:20Z

bot merge

* BlockId removal: refactor: HeaderBackend::header It changes the arguments of: - `HeaderBackend::header`, - `Client::header`, - `PeersClient::header` - `ChainApi::block_header` methods from: `BlockId<Block>` to: `Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * non-trivial usages of haeder(block_id) refactored This may required introduction of dedicated function: header_for_block_num * fmt * fix * doc fixed * ".git/.scripts/fmt.sh" * BlockId removal: refactor: HeaderBackend::expect_header It changes the arguments of `HeaderBackend::expect_header` method from: `BlockId<Block>` to: `Block::Hash` * ".git/.scripts/fmt.sh" * readme updated * ".git/.scripts/fmt.sh" * fix Co-authored-by: parity-processbot <>

michalkucharczyk added 3 commits December 8, 2022 16:16

non-trivial usages of haeder(block_id) refactored

d06359c

This may required introduction of dedicated function: header_for_block_num

fmt

ce678eb

michalkucharczyk requested review from andresilva and koute as code owners December 8, 2022 15:19

michalkucharczyk added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 8, 2022

github-actions bot added the A0-please_review Pull request needs code review. label Dec 8, 2022

michalkucharczyk removed the A0-please_review Pull request needs code review. label Dec 8, 2022

michalkucharczyk changed the title ~~mku blockid headerbackend header~~ BlockId removal: refactor: HeaderBackend::header Dec 8, 2022

fix

7f62b7f

bkchr approved these changes Dec 8, 2022

View reviewed changes

lexnv approved these changes Dec 9, 2022

View reviewed changes

davxy approved these changes Dec 9, 2022

View reviewed changes

doc fixed

1ed9150

This was referenced Dec 9, 2022

BlockId removal: refactor: HeaderBackend::header paritytech/cumulus#1977

Merged

BlockId removal: refactor: HeaderBackend::header paritytech/polkadot#6418

Merged

Merge remote-tracking branch 'origin/master' into mku-blockid-headerb…

62e73b8

…ackend-header

michalkucharczyk mentioned this pull request Dec 12, 2022

Refactoring analysis: Analyse the usage of block numbers paritytech/polkadot-sdk#53

Open

".git/.scripts/fmt.sh"

d0aaea9

michalkucharczyk added 3 commits December 14, 2022 17:46

Merge remote-tracking branch 'origin/master' into mku-blockid-headerb…

6f6385f

…ackend-header

BlockId removal: refactor: HeaderBackend::expect_header

ae66534

It changes the arguments of `HeaderBackend::expect_header` method from: `BlockId<Block>` to: `Block::Hash`

Merge remote-tracking branch 'origin/master' into mku-blockid-headerb…

e1d4dd7

…ackend-header

michalkucharczyk requested a review from acatangiu as a code owner December 15, 2022 11:46

".git/.scripts/fmt.sh"

9229dd2

acatangiu approved these changes Dec 15, 2022

View reviewed changes

michalkucharczyk requested a review from bkchr December 16, 2022 13:31

michalkucharczyk added 3 commits December 19, 2022 10:56

Merge remote-tracking branch 'origin/master' into mku-blockid-headerb…

36bb230

…ackend-header

Merge remote-tracking branch 'origin/master' into mku-blockid-headerb…

e4c3234

…ackend-header

readme updated

6d22a6c

Merge remote-tracking branch 'origin/master' into mku-blockid-headerb…

e085ba9

…ackend-header

".git/.scripts/fmt.sh"

a6b5c78

fix

9f35ae5

paritytech-processbot bot merged commit 657c808 into master Dec 20, 2022

paritytech-processbot bot deleted the mku-blockid-headerbackend-header branch December 20, 2022 09:43

jasl mentioned this pull request Jan 19, 2023

Upgrade to Polkadot v0.9.37 Phala-Network/phala-blockchain#1129

Merged

aurexav mentioned this pull request Feb 8, 2023

To polkadot-v0.9.37 darwinia-network/darwinia-2.0#267

Closed

nbaztec mentioned this pull request Feb 9, 2023

upgrade substrate to v0.9.37 moonbeam-foundation/moonbeam#2072

Merged

kacperzuk-neti mentioned this pull request Feb 14, 2023

Polkadot v0.9.37 (pallet-nfts) liberland/liberland_substrate#244

Merged

	//! let proposer = proposer_factory.init(
	//! &client.header(&BlockId::number(0)).unwrap().unwrap(),
	//! );

BlockId removal: refactor: HeaderBackend::header #12874

BlockId removal: refactor: HeaderBackend::header #12874

Uh oh!

Conversation

michalkucharczyk commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lexnv left a comment

Choose a reason for hiding this comment

Uh oh!

michalkucharczyk commented Dec 12, 2022

Uh oh!

paritytech-processbot bot commented Dec 12, 2022

Uh oh!

michalkucharczyk commented Dec 12, 2022

Uh oh!

command-bot bot commented Dec 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Dec 12, 2022

Uh oh!

michalkucharczyk commented Dec 15, 2022

Uh oh!

command-bot bot commented Dec 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Dec 15, 2022

Uh oh!

michalkucharczyk commented Dec 20, 2022

Uh oh!

paritytech-processbot bot commented Dec 20, 2022

Uh oh!

michalkucharczyk commented Dec 20, 2022

Uh oh!

command-bot bot commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Dec 20, 2022

Uh oh!

michalkucharczyk commented Dec 20, 2022

Uh oh!

paritytech-processbot bot commented Dec 20, 2022

Uh oh!

michalkucharczyk commented Dec 20, 2022

Uh oh!

paritytech-processbot bot commented Dec 20, 2022

Uh oh!

michalkucharczyk commented Dec 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

`BlockId` removal: refactor: `HeaderBackend::header` #12874

`BlockId` removal: refactor: `HeaderBackend::header` #12874

michalkucharczyk commented Dec 8, 2022 •

edited

Loading

command-bot bot commented Dec 12, 2022 •

edited

Loading

command-bot bot commented Dec 15, 2022 •

edited

Loading

command-bot bot commented Dec 20, 2022 •

edited

Loading