substrate module @ pba3 #707
Conversation
…tent into kiz-substrate-pba3
…tent into kiz-substrate-pba3
wirednkod
left a comment
wirednkod
left a comment
There was a problem hiding this comment.
some nips and tucks only (and correction of colors)
…cademy/pba-content into kiz-substrate-pba3
Co-authored-by: Nikos Kontakis <[email protected]>
…tent into kiz-substrate-pba3
| /// Use manual seal, which basically produces blocks at fixed intervals, at the given interval. | ||
| /// | ||
| /// Example: `manual-seal-3000` will produce a block every 3 seconds. | ||
| ManualSeal(u64), |
There was a problem hiding this comment.
I think, "manual seal" usually refers to when you wire this thing up to the RPC and users manually author blocks by sending rpc commands to do so. Calling this interval seal might make more sense.
There was a problem hiding this comment.
good point, it is using manual-seal under the hood, but I have indeed created my own background task to manually trigger it every x milliseconds.
|
I seem to have messed up and causes some unneeded conflicts, will start from scratch in a fresh branch. |
|
@kianenigma not you - just the folder go renamed to account for module reordering - should be OK to reopen - just make tou working dir |
closes #620 and in general preps substrate module for pba3.