Skip to content

Conversation

@wirednkod
Copy link
Member

No description provided.

@wirednkod wirednkod requested a review from nuke-web3 July 12, 2023 18:19
@nuke-web3
Copy link

This file should exist, it is intended. We should not be getting updates accidentally! That is why .gitignore ignores this file.

@nuke-web3 nuke-web3 closed this Jul 12, 2023
@wirednkod
Copy link
Member Author

@nukemandan This file should exist in the code of the people (based on their local settings) but not on git. If it exists in the git, then all updates that users do (e.g. adding color using Peacock plugin) will keep being pushed to the repo.

@wirednkod wirednkod reopened this Jul 13, 2023
@wirednkod
Copy link
Member Author

wirednkod commented Jul 13, 2023

Actually a way to fully achieve what you mention is by using skip-worktree

I will update in a new PR to do so for the specific file

@wirednkod wirednkod closed this Jul 13, 2023
@wirednkod wirednkod force-pushed the nik-fix-gitignore-of-vscode branch from d0d71bb to 02ef2f2 Compare July 13, 2023 07:26
@nuke-web3
Copy link

Nice!
TIL https://stackoverflow.com/a/1139797/9784875 and pushed up this changed to main so everyone gets the "proper" ignoring behavior.

5314b53

But this clobbered the settings I wanted. so will fix at some point... for now its' gone and ignored

nuke-web3 added a commit that referenced this pull request Jul 13, 2023
@nuke-web3 nuke-web3 deleted the nik-fix-gitignore-of-vscode branch July 27, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants