allow the use of plugins/physics without plugins/blocks as a dep#3770
Closed
Callanplays wants to merge 8 commits intoPrismarineJS:masterfrom
Closed
allow the use of plugins/physics without plugins/blocks as a dep#3770Callanplays wants to merge 8 commits intoPrismarineJS:masterfrom
Callanplays wants to merge 8 commits intoPrismarineJS:masterfrom
Conversation
Member
|
I believe we discussed removing loadInternalPlugins option in first place. What likely makes more sense is specific flags to disable specific functionality in deterministic and stable way (as opposed to some undefined behaviors as mineflayer is not intended to work without other internal modules) |
Author
|
Seems like a good idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I choose to use the built-in functionality of setting loadInternalPlugins to false so I can pick and choose which ones to load (namely, disabling the blocks plugin since the block change packets are using too much throughput for what I'm doing and are causing async lag and CPU overload).
I'd still like to use the physics plugin without requiring the bots' knowledge of the world state, so the solution I've found is to pass an air block into the physics module.