Skip to content

allow the use of plugins/physics without plugins/blocks as a dep #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Callanplays wants to merge 8 commits into from
+10 −2
Closed

allow the use of plugins/physics without plugins/blocks as a dep #3770

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8a6954e
make physics plugin robust when blocks plugin disabled
Callanplays Sep 22, 2025
e7bf0cc
add air block above note block during note test setup
Callanplays Sep 22, 2025
2ab4f60
Merge branch 'master' of https://github.com/Callanplays/mineflayer
Callanplays Oct 27, 2025
c532ca2
just return an air block
Callanplays Oct 27, 2025
925b763
revert
Callanplays Oct 27, 2025
c409598
Merge branch 'PrismarineJS:master' into master
Callanplays Oct 29, 2025
b05ba76
add empty shapesArray
Callanplays Oct 29, 2025
b6154c6
fix linting
Callanplays Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/plugins/physics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,15 @@ const PHYSICS_TIMESTEP = PHYSICS_INTERVAL_MS / 1000 // 0.05

function inject (bot, { physicsEnabled, maxCatchupTicks }) {
const PHYSICS_CATCHUP_TICKS = maxCatchupTicks ?? 4
const world = { getBlock: (pos) => { return bot.blockAt(pos, false) } }
const world = {
getBlock: (pos) => {
if (typeof bot.blockAt === 'function') {
return bot.blockAt(pos, false)
}
// if blocks plugin is unloaded, return a minimal air block object
return { name: 'air', type: 0, boundingBox: 'empty', shapes: [], position: pos }
}
}
const physics = Physics(bot.registry, world)

const positionUpdateSentEveryTick = bot.supportFeature('positionUpdateSentEveryTick')
Expand Down Expand Up @@ -76,7 +84,7 @@ function inject (bot, { physicsEnabled, maxCatchupTicks }) {
}

function tickPhysics (now) {
if (bot.blockAt(bot.entity.position) == null) return // check if chunk is unloaded
if (typeof bot.blockAt === 'function' && bot.blockAt(bot.entity.position) == null) return // check if chunk is unloaded
if (bot.physicsEnabled && shouldUsePhysics) {
physics.simulatePlayer(new PlayerState(bot, controlState), world).apply(bot)
bot.emit('physicsTick')
Expand Down
Loading