Skip to content

Conversation

@grlee77
Copy link
Contributor

@grlee77 grlee77 commented Apr 10, 2019

This PR adds a git .mailmap file.

I only added the users who had:
1.) duplicate entries due to variant names and email addresses
2.) to resolve a GitHub ID to an actual name
Let me know if you think it should also have the remaining users without duplicate entries.

Visual inspection of the output of git shortlog -sne indicates that it seems to be working as expected locally. (The length of the shortlog decreases from 42 to 34 after this change and I don't see any more duplicates).

I'm not optimistic that adding this will fix the GitHub contributors page: some posts I read elsewhere indicated that GitHub itself doesn't use this file, but perhaps that could have changed in the meantime.

Another case of missing data from GitHub's contributors page:
@sciunto is actually the 7th highest contributor in number of commits (29) in the output of git shortlog -sne but doesn't show up on the contributors page on GitHub. I assume this is because the email address associated with the commits has spaces instead of @ or . in it. Assuming that was intentional, I didn't want to presume to add it here. Please let me know if you would like it to be there.

@0-tree: As a past contributor here, please provide your real name if you would like your contribution to be credited using it.

@rthr-rllr
Copy link
Contributor

rthr-rllr commented Apr 11, 2019 via email

@rgommers rgommers merged commit a35a823 into PyWavelets:master Apr 11, 2019
@rgommers
Copy link
Member

LGTM, merged. Thanks @grlee77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants