Handle when saliency_scores not equal to len_text #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a corner-case when `saliency_scores` length is not equal to `len_text` , this happens when the query budget limits calculations of `leave_one_results`. Fixes Issue raised by @pratyushmaini in QData#654
jxmorris12
reviewed
Jun 29, 2022
Comment on lines
+68
to
+76
|
|
||
| # Exit Loop when search_over is True - but we need to make sure delta_ps | ||
| # is the same size as softmax_saliency_scores | ||
| if search_over: | ||
| delta_ps = delta_ps + [0.0] * ( | ||
| len(softmax_saliency_scores) - len(delta_ps) | ||
| ) | ||
| break | ||
|
|
Collaborator
There was a problem hiding this comment.
Thanks for fixing this bug.
jxmorris12
approved these changes
Jun 29, 2022
Collaborator
|
Closes #654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary
There is a corner-case when
saliency_scoreslength is not equal tolen_text,this happens when the query budget limits calculations of
leave_one_results.Additions
Changes
search_overcheck to the start of the loop .delta_psupdate when search_over = True.Deletions
Fixes Issue raised by @pratyushmaini in #654
Checklist
.rstfile inTextAttack/docs/apidoc.'