Skip to content

Handle when saliency_scores not equal to len_text #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jxmorris12 merged 2 commits into from
Jun 29, 2022
Merged

Handle when saliency_scores not equal to len_text #674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dbe756
Handle when saliency_scores not equal to len_text
VijayKalmath Jun 23, 2022
1d429b1
Fix Lint Error
VijayKalmath Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions textattack/search_methods/greedy_word_swap_wir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ def _get_index_order(self, initial_text):
# compute the largest change in score we can find by swapping each word
delta_ps = []
for idx in indices_to_order:

# Exit Loop when search_over is True - but we need to make sure delta_ps
# is the same size as softmax_saliency_scores
if search_over:
delta_ps = delta_ps + [0.0] * (
len(softmax_saliency_scores) - len(delta_ps)
)
break

Comment on lines +68 to +76
Copy link
Collaborator

@jxmorris12 jxmorris12 Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug.

transformed_text_candidates = self.get_transformations(
initial_text,
original_text=initial_text,
Expand All @@ -84,12 +93,6 @@ def _get_index_order(self, initial_text):
max_score_change = np.max(score_change)
delta_ps.append(max_score_change)

# Exit Loop when search_over is True - but we need to make sure delta_ps
# is the same size as softmax_saliency_scores
if search_over:
delta_ps = delta_ps + [0.0] * (len_text - len(delta_ps))
break

index_scores = softmax_saliency_scores * np.array(delta_ps)

elif self.wir_method == "delete":
Expand Down