[CORE] .hiverc is loaded twice making create function throw exception #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Could you add |
Collaborator
|
.hiverc -> |
beliefer
reviewed
Sep 25, 2019
| sc = spark.sparkContext | ||
| processInitFile(conf) | ||
| // we shouldn't load .hiverc twice | ||
| // processInitFile(conf) |
Collaborator
There was a problem hiding this comment.
processInitFile is only used for load .hiverc?
Collaborator
Author
There was a problem hiding this comment.
processInitFileis only used for load.hiverc?
Yes
Collaborator
There was a problem hiding this comment.
I think we should change coment as 'Don't call processInitFile again to avoid load .hiverc twice.'
beliefer
pushed a commit
that referenced
this pull request
Sep 29, 2019
…45 **What changes were proposed in this pull request** If user's `.hiverc` contains sql like 'create temporary function funA as xx.xx', bin/spark-xsql will register it in functionRegistry of local `SparkSession`'s `XSQLSessionCatalog` in the beginning. When some sql causes `SparkSession` restart to run on yarn, the old `XSQLSessionCatalog` is passed to new started `SparkSession`. It's meaning that funA has existed in functionRegistry. So we should not run `.hiverc` again after SparkSession is restarted.
beliefer
pushed a commit
that referenced
this pull request
Sep 29, 2019
…45 **What changes were proposed in this pull request** If user's `.hiverc` contains sql like 'create temporary function funA as xx.xx', bin/spark-xsql will register it in functionRegistry of local `SparkSession`'s `XSQLSessionCatalog` in the beginning. When some sql causes `SparkSession` restart to run on yarn, the old `XSQLSessionCatalog` is passed to new started `SparkSession`. It's meaning that funA has existed in functionRegistry. So we should not run `.hiverc` again after SparkSession is restarted.
Collaborator
|
Thanks! Merged to master and branch-0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
If user's
.hiverccontains sql like 'create temporary function funA as xx.xx', bin/spark-xsql will register it in functionRegistry of localSparkSession'sXSQLSessionCatalogin the beginning. When some sql causesSparkSessionrestart to run on yarn, the oldXSQLSessionCatalogis passed to new startedSparkSession. It's meaning that funA has existed in functionRegistry. So we should not run.hivercagain after SparkSession is restarted.