Skip to content

[CORE] .hiverc is loaded twice making create function throw exception #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WeiWenda wants to merge 2 commits into from
Closed

[CORE] .hiverc is loaded twice making create function throw exception #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abc8be4
.hiverc is loaded twice making create function throw exception
WeiWenda Sep 25, 2019
17b7ee4
.hiverc is loaded twice making create function throw exception
WeiWenda Sep 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sql/xsql-shell/src/main/scala/org/apache/spark/sql/xsql/shell/SparkXSQLShell.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ object SparkXSQLShell extends Logging {
sqlContext = spark.sqlContext
conf = spark.sparkContext.getConf
sc = spark.sparkContext
processInitFile(conf)
// Don't call processInitFile again to avoid load .hiverc twice.
// For more details, please see https://github.com/Qihoo360/XSQL/pull/45
// processInitFile(conf)
Copy link
Collaborator

@beliefer beliefer Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

processInitFile is only used for load .hiverc?

Copy link
Collaborator Author

@WeiWenda WeiWenda Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

processInitFile is only used for load .hiverc?

Yes

Copy link
Collaborator

@beliefer beliefer Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change coment as 'Don't call processInitFile again to avoid load .hiverc twice.'

}

def initialize(sqlContent: String, conf: SparkConf) = {
Expand Down