[JDBC] Fix mysql datasource can't partition #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
mysql -> |
Collaborator
|
The PR fixs the bug. -> The PR fixes the bug . |
Collaborator
Author
Thanks for your correction |
beliefer
reviewed
Oct 18, 2019
| } | ||
| if (partitionsParameters.nonEmpty) { | ||
| specialProperties += ((s"${dsName}.${dbName}.${tbName}", partitionsParameters)) | ||
| } |
Collaborator
There was a problem hiding this comment.
Option(partitionsMap(dbName)(tbName)).foreach{ m =>
specialProperties += ((s"${dsName}.${dbName}.${tbName}", m))
}
beliefer
reviewed
Oct 21, 2019
| tablePartitionsMap.get.get(tbName).foreach { m => | ||
| specialProperties += ((s"${dsName}.${dbName}.${tbName}", m)) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Option(partitionsMap(dbName)).map{ tablePartitionsMap =>
Option(tablePartitionsMap(tbName)).foreach { m =>
specialProperties += ((s"${dsName}.${dbName}.${tbName}", m))
}
}
Collaborator
Author
There was a problem hiding this comment.
Thanks for your advice， but the code can't pass.
beliefer
changed the title
beliefer
pushed a commit
that referenced
this pull request
Oct 22, 2019
This PR solves the problem that MySQL data source can't partition. The current code don't load partition information of MySQL into memory when `cache.level` is 1 . The PR fixes the bug.
beliefer
pushed a commit
that referenced
this pull request
Oct 22, 2019
This PR solves the problem that MySQL data source can't partition. The current code don't load partition information of MySQL into memory when `cache.level` is 1 . The PR fixes the bug.
Collaborator
|
Thanks! Merged to master and branch-0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR solves the problem that MySQL data source can't partition. The current code don't load partition information of MySQL into memory when
cache.levelis 1 . The PR fixes the bug.How was this patch tested?
No UT.