Skip to content

[JDBC] Fix mysql datasource can't partition #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wenfang6 wants to merge 3 commits into from
Closed

[JDBC] Fix mysql datasource can't partition #54

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a495e97
Fix mysql datasource can't partition
Oct 18, 2019
13cfae7
Optimization code
Oct 21, 2019
3d5c109
Optimization code
Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Optimization code
  • Loading branch information
wenfang committed Oct 22, 2019
commit 3d5c1099accba437e006d34e2d9d0247b8b30ffc
5 changes: 2 additions & 3 deletions sql/xsql/src/main/scala/org/apache/spark/sql/xsql/manager/MysqlManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,8 @@ private[xsql] class MysqlManager(conf: SparkConf) extends DataSourceManager with
dsName: String,
dbName: String,
tbName: String): Unit = {
val tablePartitionsMap = partitionsMap.get(dbName)
if (tablePartitionsMap != None) {
tablePartitionsMap.get.get(tbName).foreach { m =>
partitionsMap.get(dbName).foreach { tablePartitionsMap =>
tablePartitionsMap.get(tbName).foreach {m =>
specialProperties += ((s"${dsName}.${dbName}.${tbName}", m))
}
}
Copy link
Collaborator

@beliefer beliefer Oct 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  Option(partitionsMap(dbName)).map{ tablePartitionsMap =>
    Option(tablePartitionsMap(tbName)).foreach { m =>
      specialProperties += ((s"${dsName}.${dbName}.${tbName}", m))
    }
  }

Copy link
Collaborator Author

@wenfang6 wenfang6 Oct 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice， but the code can't pass.

Copy link
Collaborator

@beliefer beliefer Oct 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Expand Down