initial rubocop fixes

app/controllers/api/feedback_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Api
   class FeedbackController < ApiController
     before_action :authorize_user
@@ -31,7 +33,7 @@ def url_params
 
     def base_params
       params.fetch(:feedback, {}).permit(
-        :content,
+        :content
       ).merge(url_params)
     end
   end

app/models/feedback.rb

@@ -4,7 +4,6 @@ class Feedback < ApplicationRecord
   belongs_to :school_project
   validates :content, presence: true
   validates :user_id, presence: true
-  validates :school_project, presence: true
   validate :user_has_the_school_owner_or_school_teacher_role_for_the_school
   validate :parent_project_belongs_to_lesson
   validate :parent_project_belongs_to_school_class
@@ -25,6 +24,7 @@ def user_has_the_school_owner_or_school_teacher_role_for_the_school
   def parent_project_belongs_to_lesson
     parent_project = school_project&.project&.parent
     return if parent_project&.lesson_id.present?
+
     msg = "Parent project '#{parent_project&.id}' does not belong to a 'lesson'"
     errors.add(:user, msg)
   end

lib/concepts/feedback/operations/create.rb

@@ -24,15 +24,13 @@ def call(feedback_params:)
       def build_feedback(feedback_hash)
         project = Project.find_by(identifier: feedback_hash[:identifier])
         school_project = project&.school_project
-        if school_project.nil?
-          raise "School project not found for identifier: #{feedback_hash[:identifier]}"
-        end
+        raise "School project not found for identifier: #{feedback_hash[:identifier]}" if school_project.nil?
+
         # replace identifier with school_project_id
         feedback_hash[:school_project_id] = school_project.id
         feedback_hash.delete(:identifier)
-        new_feedback = Feedback.new(feedback_hash)
-        new_feedback
+        Feedback.new(feedback_hash)
       end
     end
   end
-end
+end

spec/factories/feedback.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # # frozen_string_literal: true
 
 FactoryBot.define do
@@ -16,4 +18,4 @@
       student_project { create(:project, parent: parent_project, user_id: student.id) }
     end
   end
-end
+end

spec/models/feedback_spec.rb

@@ -43,7 +43,7 @@
     it 'validates that the user is the class teacher for the school project' do
       school_class = create(:school_class, teacher_ids: [teacher.id], school:)
       parent_project = create(:project, user_id: teacher.id, school:, lesson: create(:lesson, school:, school_class:, user_id: teacher.id))
-      school_project = create(:school_project, school:, project: create(:project, parent: parent_project))      
+      school_project = create(:school_project, school:, project: create(:project, parent: parent_project))
       other_teacher = create(:teacher, school:)
       feedback = build(:feedback, school_project:, user_id: other_teacher.id)
       expect(feedback).not_to be_valid
@@ -55,4 +55,4 @@
       expect(feedback).to be_valid
     end
   end
-end
+end