-
Notifications
You must be signed in to change notification settings - Fork 5
Create feedback #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Create feedback #601
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e3dadb5
WIP: create feedback route
loiswells97 195eaaf
fixing
loiswells97 7e78390
Update feedback.rb
loiswells97 1dc0f11
improving feedback validations and adding factory and model tests
loiswells97 8fa4791
adding abilities
loiswells97 a560c73
testing feedback create operation
loiswells97 56f32da
tidying
loiswells97 1ec8287
initial rubocop fixes
loiswells97 1631cf9
Merge branch 'main' into create-feedback
loiswells97 826e1a4
updating schema version
loiswells97 788b447
remove unneeded test
loiswells97 8a1d61c
some rubocop fixes
loiswells97 054be3f
refactoring feedback factory to please rubocop
loiswells97 c57741d
adding authorisation for feedback creation
loiswells97 40ab7c5
add feedback auditing
loiswells97 7e1ea4a
tidying
loiswells97 3ad056b
tidying and request specs
loiswells97 581e3aa
rubocop fixes
loiswells97 59ecd17
adding comments to explain params
loiswells97 066ee40
removing commented code
loiswells97 5678604
fixing papertrail by adding meta migration to versions table
loiswells97 96c4b92
remove redundant operations directory
loiswells97 a3c612b
factoring out teacher project ids
loiswells97 8875291
factoring feedback template out into a partial
loiswells97 2adbcef
simplify feedback creation error handling
loiswells97 f08ba8c
Merge branch 'main' into create-feedback
loiswells97 1c801ae
refactor error handling slightly to catch non-validation errors
loiswells97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
factoring out teacher project ids
- Loading branch information
commit a3c612b4967e9dd14108450afd6ca82507dc70f6
There are no files selected for viewing
danhalson marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.