chore: update marked to version 0.6.0 #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
force-pushed
the
update/marked
branch
2 times, most recently
from
30bc62a to
ec5c0f9
Compare
Contributor
Author
|
Opened DefinitelyTyped/DefinitelyTyped#31834 to address the failures, will update accordingly here when possible. |
softbrix
referenced
this pull request
Jan 4, 2019
Updated version for the marked dependency to an official release.
|
Hi there! Can this PR be merged? What else needs to be reviewed so that this PR can be successfully closed out? I am very much looking forward to this change here: 809e7f2 As I really want to integrate this wonderful open source tool into my project. Thanks so much guys for being such a cool community. |
RomanHotsiy
reviewed
Jan 5, 2019
src/services/MarkdownRenderer.ts
Outdated
| ); | ||
| } | ||
| return this.originalHeadingRule(text, level, raw); | ||
| return this.originalHeadingRule(text, level, raw, this.slugger); |
Member
There was a problem hiding this comment.
Looks like you don't need to manually create slugger.
Just pass it through function parameters:
headingRule = (text: string, level: number, raw: string, slugger: marked.Slugger) => {
// ...
return this.originalHeadingRule(text, level, raw, slugger);
}
Contributor
Author
There was a problem hiding this comment.
Good catch, addressed.
RomanHotsiy
requested changes
Jan 5, 2019
Member
RomanHotsiy
left a comment
RomanHotsiy
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Added one comment.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new release includes markedjs/marked#1383.
Would it be possible to also release a new version of redoc and redoc-cli?
Thank you.